Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename-Protocol-methods-into-methodSelectors #4879

Conversation

@jecisc
Copy link
Member

jecisc commented Oct 10, 2019

The API of Protocol is, currently, misleading. A protocol has a method #methods but this one does not return methods but selectors.

In this PR I updated the API to #methodSelectors to be explicit.

jecisc added 3 commits Oct 10, 2019
…d #methods but this one does not return methods but selectors.

In this PR I updated the API to #methodSelectors to be explicit.
jecisc added 2 commits Oct 10, 2019
@MarcusDenker

This comment has been minimized.

Copy link
Member

MarcusDenker commented Oct 10, 2019

but bootstrap is failing, needs some more transformations as part of the PR

@jecisc

This comment has been minimized.

Copy link
Member Author

jecisc commented Oct 10, 2019

@MarcusDenker I'm on it.

@jecisc

This comment has been minimized.

Copy link
Member Author

jecisc commented Oct 10, 2019

@MarcusDenker Fixed.

@jecisc

This comment has been minimized.

Copy link
Member Author

jecisc commented Oct 10, 2019

Running the tests I see some deprecations. I'll fixe them also.

@jecisc

This comment has been minimized.

Copy link
Member Author

jecisc commented Oct 10, 2019

Test failure unrelated.

@MarcusDenker MarcusDenker merged commit 228455c into pharo-project:Pharo8.0 Oct 11, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/benchmarks The benchmarks show regressions.
Details
continuous-integration/jenkins/pr-merge This commit has test failures
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.