Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4881-RBImplementedNotSentRule-is-disabled #4882

Conversation

@MarcusDenker
Copy link
Member

MarcusDenker commented Oct 10, 2019

  • enable RBImplementedNotSentRule
  • document #excludedRuleNames
  • remove unsent message
  • improve rule a little

fixes #4881

- document #excludedRuleNames
- remove unsent message
- improve rule a little

fixes #4881
- improve comments
Copy link
Member

Ducasse left a comment

Smalltalk globals -> self class environment?

@MarcusDenker

This comment has been minimized.

Copy link
Member Author

MarcusDenker commented Oct 11, 2019

for now it would work with "self class environment". But that is the environment the tool is in, while what we conceptional want is "please analyse this environment", something that we do not model right now.

For me then using "Smalltalk globals" does not feel that bad because it makes clear: "analyse the global environment, if you want something else there is still work todo", while "self class environment" uses explicitly the environment the tool is installed in as if this is what we want. And it is not.

@MarcusDenker MarcusDenker merged commit 3490798 into pharo-project:Pharo8.0 Oct 11, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/benchmarks The benchmarks show regressions.
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.