Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4886-Epicea-cant-multi-select-sessions #4888

Conversation

@tinchodias
Copy link
Contributor

tinchodias commented Oct 10, 2019

Fix #4886. Allow multiselection of session logs.

tinchodias added 3 commits Oct 4, 2019
@@ -1,5 +1,5 @@
"
An EpDeferrerTest is a test class for testing the behavior of EpDeferrer
An EpDeferrerTest is a test class for testing the behavior of OmDeferrer

This comment has been minimized.

Copy link
@tinchodias

tinchodias Oct 10, 2019

Author Contributor

Offtopic: fix typo

@tinchodias

This comment has been minimized.

Copy link
Contributor Author

tinchodias commented Oct 10, 2019

By mistake, this branch includes the fix to #2853, which is not reviewed/merged yet.

I think we can just wait to merge the other, without rebasing...

@tinchodias

This comment has been minimized.

Copy link
Contributor Author

tinchodias commented Oct 14, 2019

This PR is ready to be reviewed now that the fix to #2853 was merged.

Copy link
Member

MarcusDenker left a comment

tested the download from the CI, works

@MarcusDenker MarcusDenker merged commit 5b7fab0 into pharo-project:Pharo8.0 Nov 5, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/benchmarks The benchmarks show regressions.
Details
continuous-integration/jenkins/pr-merge This commit has test failures
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews
@tinchodias tinchodias deleted the tinchodias:4886-Epicea-cant-multi-select-sessions branch Nov 5, 2019
@tinchodias

This comment has been minimized.

Copy link
Contributor Author

tinchodias commented Nov 5, 2019

thanks Marcus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.