Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-command-to-browse-rule-class #4890

Merged

Conversation

@jecisc
Copy link
Member

jecisc commented Oct 11, 2019

Add a command to Calypso to browse a critic class in the extra menu.

@MarcusDenker MarcusDenker merged commit 2268d33 into pharo-project:Pharo8.0 Oct 11, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews
Copy link
Contributor

dionisiydk left a comment

It should be a subclass of ClyCritiqueCommand. It provides required variables and initialization. So you will need just an execution method.

And I would rename it to ClyBrowseCritiqueRuleCommand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.