Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBRefersToClassRule-should-ignore-isAbstract-methods #4892

Conversation

@jecisc
Copy link
Member

jecisc commented Oct 11, 2019

#isAbstract methods need to hardcode classes to be useful in hierarchy. RBRefersToClussRule should not declare those methods as failures to the rule.

This PR also add tests to this rule.

jecisc added 2 commits Oct 11, 2019
…y. RBRefersToClussRule should not declare those methods as failures to the rule.

This PR also add tests to this rule.
@Ducasse Ducasse merged commit 2eafa8c into pharo-project:Pharo8.0 Oct 11, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit is being built
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.