Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBRefersToClassRule-should-ignore-isAbstract-methods #4892

Merged
merged 2 commits into from Oct 11, 2019
Merged

RBRefersToClassRule-should-ignore-isAbstract-methods #4892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6183774
#isAbstract methods need to hardcode classes to be useful in hierarch…
jecisc Oct 11, 2019
43bb03a
Some cleanings.
jecisc Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/GeneralRules-Tests/RBAbstractMockToTestRefersToClassRule.class.st
View file
Open in desktop
@@ -0,0 +1,23 @@
"
I am a Mock to test RBRefersToClassRule.
"
Class {
#name : #RBAbstractMockToTestRefersToClassRule,
#superclass : #Object,
#category : #'GeneralRules-Tests-Mock'
}

{ #category : #testing }
RBAbstractMockToTestRefersToClassRule class >> isAbstract [
^ self = RBAbstractMockToTestRefersToClassRule
]

{ #category : #helpers }
RBAbstractMockToTestRefersToClassRule >> methodHardCodingClass [
^ RBAbstractMockToTestRefersToClassRule
]

{ #category : #helpers }
RBAbstractMockToTestRefersToClassRule >> methodWithoutCodingClass [
^ 42
]
7 changes: 2 additions & 5 deletions src/GeneralRules-Tests/RBGlobalVariableRuleTest.class.st
View file
Open in desktop
Expand Up @@ -40,8 +40,7 @@ RBGlobalVariableRuleTest >> methodUsesGlobal2 [

{ #category : #tests }
RBGlobalVariableRuleTest >> testTheRuleCanCheckMethodsWithDifferentKindsOfLiterals [
self assert: (RBGlobalVariablesUsage new check: self class>>#methodNotUsesGlobal2)
isEmpty
self assertEmpty: (RBGlobalVariablesUsage new check: self class >> #methodNotUsesGlobal2)
]

{ #category : #tests }
Expand All @@ -51,7 +50,5 @@ RBGlobalVariableRuleTest >> testTheRuleOnlyDetect2MethodsWithGlobalVariables [

{ #category : #tests }
RBGlobalVariableRuleTest >> testTheRuleOnlyMethodUsesGlobal1And2 [
self
assert: (self applyingCritiques collect: #selector) asSet
equals: {#methodUsesGlobal . #methodUsesGlobal2} asSet
self assertCollection: (self applyingCritiques collect: #selector) hasSameElements: {#methodUsesGlobal . #methodUsesGlobal2}
]
28 changes: 28 additions & 0 deletions src/GeneralRules-Tests/RBRefersToClassRuleTest.class.st
View file
Open in desktop
@@ -0,0 +1,28 @@
"
A RBRefersToClassRuleTest is a test class for testing the behavior of RBRefersToClassRule
"
Class {
#name : #RBRefersToClassRuleTest,
#superclass : #TestCase,
#category : #'GeneralRules-Tests-Migrated'
}

{ #category : #helpers }
RBRefersToClassRuleTest >> newRule [
^ RBRefersToClassRule new
]

{ #category : #tests }
RBRefersToClassRuleTest >> testIsAbstractNotDetected [
self assertEmpty: (self newRule check: RBAbstractMockToTestRefersToClassRule class>> #isAbstract)
]

{ #category : #tests }
RBRefersToClassRuleTest >> testRuleDetectHardCodedClass [
self denyEmpty: (self newRule check: RBAbstractMockToTestRefersToClassRule >> #methodHardCodingClass)
]

{ #category : #tests }
RBRefersToClassRuleTest >> testRuleWithoutHardCodedClass [
self assertEmpty: (self newRule check: RBAbstractMockToTestRefersToClassRule >> #methodWithoutCodingClass)
]
8 changes: 4 additions & 4 deletions src/GeneralRules-Tests/RBSmalllintTest.class.st
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ RBSmalllintTest >> assertEnvironment: anEnvironment hasAllClassesOfTheResult: cr

critiques do: [ :crit |
| target |
target := crit sourceAnchor entity.
target := crit entity.
self assert: target isClass.
self assert: (anEnvironment includesClass: target) ]
]
Expand All @@ -24,7 +24,7 @@ RBSmalllintTest >> assertEnvironment: anEnvironment hasAllMethodsOfTheResult: cr

critiques do: [ :crit |
| target |
target := crit sourceAnchor entity.
target := crit entity.
self assert: target isCompiledMethod.
self assert: (anEnvironment includesMethod: target) ]
]
Expand All @@ -49,14 +49,14 @@ RBSmalllintTest >> assertIsValidRule: aRule [
RBSmalllintTest >> assertResult: critiques hasAllClassesInEnvironment: anEnvironment [
anEnvironment classesDo: [ :class |
self assert: (critiques anySatisfy: [ :crit |
crit sourceAnchor entity instanceSide = class instanceSide ]) ]
crit entity instanceSide = class instanceSide ]) ]
]

{ #category : #asserting }
RBSmalllintTest >> assertResult: critiques hasAllMethodsInEnvironment: anEnvironment [
anEnvironment methodsDo: [ :method |
self assert: (critiques anySatisfy: [ :crit |
crit sourceAnchor entity = method ]) ]
crit entity = method ]) ]
]

{ #category : #private }
Expand Down
3 changes: 3 additions & 0 deletions src/GeneralRules/RBRefersToClassRule.class.st
View file
Open in desktop
Expand Up @@ -23,6 +23,9 @@ RBRefersToClassRule class >> uniqueIdentifierName [
{ #category : #running }
RBRefersToClassRule >> basicCheck: aMethod [
| class |
"The class method #isAbstract needs to explicitly hardcode class references. So we do not criticize this."
(aMethod methodClass isClassSide and: [ aMethod selector = #isAbstract ]) ifTrue: [ ^ false ].

class := aMethod methodClass instanceSide.
^ aMethod hasLiteral: (class environment associationAt: class name ifAbsent: [ ^ false ])
]
Expand Down