Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RB - Improve rename method presenter #9234

Merged
merged 12 commits into from May 4, 2021

Conversation

Lin777
Copy link
Contributor

@Lin777 Lin777 commented May 3, 2021

Fixes #9194
Fixes #9139
Fixes #5855

Video: https://youtu.be/mYeFbpMQhs8

Now you can rename arguments when you are renaming or extractirng methods

Rename method presenter
imagen

When you are adding parameters you can add more than one parameter, and also you can rename parameters

Add argument presenter
imagen

@Lin777 Lin777 changed the title RB - Improve rename method preview RB - Improve rename method presenter May 3, 2021
@Lin777 Lin777 closed this May 3, 2021
@Lin777 Lin777 reopened this May 3, 2021
@Ducasse
Copy link
Member

Ducasse commented May 4, 2021

@Lin777 this is cool.
Now do you invoke the RenameArgumentRefactoring because the input from the user may be bogus.

@Ducasse
Copy link
Member

Ducasse commented May 4, 2021

I read the code and I saw it. Quite a lot of work!

@Ducasse Ducasse merged commit de00bae into pharo-project:Pharo9.0 May 4, 2021
@Lin777
Copy link
Contributor Author

Lin777 commented May 5, 2021

@Lin777 this is cool.
Now do you invoke the RenameArgumentRefactoring because the input from the user may be bogus.

Yes, in this change I focus on the view, but I will improve the renaming using RenameArgumentRefactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants