Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a button "View on Github" when creating a PR #1044

Closed
jecisc opened this issue Oct 29, 2018 · 4 comments
Closed

Show a button "View on Github" when creating a PR #1044

jecisc opened this issue Oct 29, 2018 · 4 comments

Comments

@jecisc
Copy link
Contributor

jecisc commented Oct 29, 2018

When a PR is created on github via the github plugin of Iceberg it would be great to have a "View on Github" button.

Most of the time I got check the PR after opening it.

In Pharo 7 it is possible to do that with a WebBrowser command. I don't know if it is possible to add a button in a Growl notification.

@jecisc
Copy link
Contributor Author

jecisc commented Oct 30, 2018

Apparently, it will be hard to create a button in a growl morph (It is a subclass of TextMorph :'( ).

We can still make it clickable.

@estebanlm
Copy link
Collaborator

in theory, a TextMorph should allow that.
and at least, it should allow a link.

but I wonder if we want that, since it would change the UI : until now, growl messages are just that: messages.

can't we think in another solution?

@jecisc
Copy link
Contributor Author

jecisc commented Oct 30, 2018

I was thinking about doing a "NotificationMorph" close to native notifications (you can embed images, buttons, icons, links...). But I gave up because I did not find a way to manage the layout of a morph that is not in a window :P

@jecisc
Copy link
Contributor Author

jecisc commented Oct 30, 2018

Merged in #1047 .

@jecisc jecisc closed this as completed Oct 30, 2018
@estebanlm estebanlm removed the review label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants