Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to move an image file #26

Open
npasserini opened this issue May 23, 2016 · 7 comments
Open

Allow to move an image file #26

npasserini opened this issue May 23, 2016 · 7 comments

Comments

@npasserini
Copy link
Contributor

Local git repos in iceberg-cache should keep being valid, either because they have been moved with the image or because we re-create the local clones from their remote counterparts.

Other git repos (with absolute file locations) will be expected to be in the same place, regardless of the image being moved.

@guillep
Copy link
Member

guillep commented Apr 6, 2018

We should test better non-bound repositories

@seandenigris
Copy link
Contributor

The fix seems simple. Edit this one method as follows to not resolve:

IceLibgitRepository >> #localRepositoriesLocation
	^ FileLocator localDirectory / #iceberg

PR incoming...

@seandenigris
Copy link
Contributor

seandenigris commented Oct 4, 2019

Not sure how to do the PR @estebanlm @guillep. If I add this as a remote repo in P8, many unrelated changes show up before I do anything...

@guillep
Copy link
Member

guillep commented Oct 4, 2019 via email

seandenigris added a commit to seandenigris/Pharo-Preferences that referenced this issue Oct 4, 2019
Stash here until we can use a bit and also get an answer on how to PR to Iceberg
pharo-vcs/iceberg#26
@seandenigris
Copy link
Contributor

seandenigris commented Oct 4, 2019

When trying to check out that branch, it shows quite a few changes in Pharo 8:
Screenshot 2019-10-04 16 06 38

Bump, @estebanlm @guillep

@seandenigris
Copy link
Contributor

@estebanlm @guillep Bump!! It would be nice to fix this in time for P8 :)

@seandenigris
Copy link
Contributor

@tesonep's merge seems to have fixed this. Can someone close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants