New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis is not building Pull Requests #634

Closed
guillep opened this Issue Apr 13, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@guillep
Member

guillep commented Apr 13, 2018

Currently the build requires an ssh key to clone test repositories.
The repository contains an encrypted key and they variables for its decryption are safe encrypted variables in travis, which are ignored for security reasons in the build.

However, in general a key should not be needed to clone...

@guillep

This comment has been minimized.

Member

guillep commented Apr 13, 2018

cloning from github requires to have a github account if using ssh. I think for now not using ssh in tests is not a bad solution...

@guillep

This comment has been minimized.

Member

guillep commented Apr 13, 2018

So I've preferred to:

  • use the already existing parameterizable tests to run metacello integration tests using ssh and https tests locally
  • then in CI ssh tests are skipped for now

This allows us at least to test metacello integration. Testing ssh connection is another story...

@guillep

This comment has been minimized.

Member

guillep commented Apr 13, 2018

@guillep guillep closed this Apr 13, 2018

@guillep guillep added this to the 0.7.3 milestone Apr 20, 2018

@estebanlm estebanlm referenced this issue Apr 24, 2018

Merged

release 0.7.3 #684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment