Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGit_GIT_ERROR: error authenticating: no auth sock variable loading a Tonel based baseline dependency in smalltalkCI #643

Closed
gcotelli opened this Issue Apr 18, 2018 · 13 comments

Comments

Projects
None yet
4 participants
@gcotelli
Copy link
Contributor

gcotelli commented Apr 18, 2018

smalltalkCI now supports the tonel file format and the iceberg-metacello integration is not disabled anymore.

Loading a project depending in another project both in Tonel format gives this error on Pharo 7:

LGitReturnCodeEnum>>handleLGitReturnCode
LGitRepository(LGitExternalObject)>>withReturnHandlerDo:
LGitRepository>>clone:options:to:
LGitRepository>>clone:options:
IceGitScpRemote(IceGitRemote)>>cloneIn:subdirectory:
IceRepositoryCreator>>cloneRepository

Checkout https://travis-ci.org/ba-st/Boardwalk/jobs/368090233

In Pharo 6.1 is working Ok.

@estebanlm

This comment has been minimized.

Copy link
Collaborator

estebanlm commented Apr 18, 2018

the error is this one:

LGit_GIT_ERROR: error authenticating: no auth sock variable.

ant technically is not an iceberg problem either :)
it means you do not have SSH agent in your test system.

but... metacello integration should have fallbacked to HTTPS (instead SSH).
And that's a bug :)

@estebanlm estebanlm added the bug label Apr 18, 2018

@estebanlm estebanlm added this to the 0.7.3 milestone Apr 18, 2018

@estebanlm estebanlm added the important label Apr 19, 2018

estebanlm added a commit that referenced this issue Apr 20, 2018

restore retry with HTTPS fallback when creating repositories after a …
…metacello adapter (to allow install on non-authenticathed machines).

fixes #643
@estebanlm

This comment has been minimized.

Copy link
Collaborator

estebanlm commented Apr 20, 2018

should be fixed on 0.7.3

@estebanlm estebanlm closed this Apr 20, 2018

@estebanlm estebanlm referenced this issue Apr 24, 2018

Merged

release 0.7.3 #684

@gcotelli

This comment has been minimized.

Copy link
Contributor Author

gcotelli commented May 1, 2018

This is supposed to be fixed. But it's still failing with the latest pharo 7 version. Checkout this build from today: https://travis-ci.org/ba-st/Willow/jobs/373448344

@guillep guillep reopened this May 2, 2018

@guillep

This comment has been minimized.

Copy link
Member

guillep commented May 2, 2018

Ok, I assume the problem is that Iceberg is not catching the "absence of ssh agent" error. I'll try to get a way to reproduce it in a test

@guillep

This comment has been minimized.

Copy link
Member

guillep commented May 2, 2018

Ok, it was apparently that. In #752 I've introduced:

  • new metacello integration tests for it that run on the CI
  • some architectural renraku rules to validate that we are correctly handling errors
  • plus a pass on iceberg to check all violated rules
@gcotelli

This comment has been minimized.

Copy link
Contributor Author

gcotelli commented May 2, 2018

@jecisc

This comment has been minimized.

Copy link
Contributor

jecisc commented May 2, 2018

What is really weird is that it works in Pharo 6.1 but not 7.

I have the same problem with one of my project.

@guillep

This comment has been minimized.

Copy link
Member

guillep commented May 2, 2018

@gcotelli I'd like to build a more interesting integration test for it in the CI. Can you tell me if this happens only for tonel projects or also for filetree? I'd say it should happen for both...

@jecisc Iceberg - metacello integration in pharo 6 is disabled by default :)

@gcotelli

This comment has been minimized.

Copy link
Contributor Author

gcotelli commented May 2, 2018

@jecisc

This comment has been minimized.

Copy link
Contributor

jecisc commented May 3, 2018

@guillep

This comment has been minimized.

Copy link
Member

guillep commented May 3, 2018

@gcotelli can you confirm if this works on your side too? If so, I'll close this issue :)

@gcotelli

This comment has been minimized.

Copy link
Contributor Author

gcotelli commented May 3, 2018

@guillep

This comment has been minimized.

Copy link
Member

guillep commented May 3, 2018

Nice! Thanks

@guillep guillep closed this May 3, 2018

@guillep guillep modified the milestones: 0.7.3, 0.7.5 May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.