New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iceberg does not correctly recognize packages #678

Closed
guillep opened this Issue Apr 23, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@guillep
Member

guillep commented Apr 23, 2018

Iceberg tries to read the packages in a commit using the .properties file that is in disk. However, this is not always suitable. For example:

  • I downloaded a new pharo image
  • I cloned pharo from my fork
    • I was in unknown commit state (I had to do a fetch)
    • my fork has master as default branch, which was still in filetree format

Then once the fetch was done, iceberg tried to read the commit's packages (in tonel) using the filetree reader (as said by my disk working copy).

This should be solved by using the commit's properties file instead of the working copy's one.

@guillep

This comment has been minimized.

Member

guillep commented Apr 23, 2018

Commit 989696e publishes a fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment