From 1a633246193930edcdf5c2dee2f1834ede115752 Mon Sep 17 00:00:00 2001 From: Grayside Date: Mon, 28 Mar 2016 15:33:56 -0700 Subject: [PATCH 1/3] Improve performance and cacheability of composer install. --- tasks/composer.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tasks/composer.js b/tasks/composer.js index 27a232ee..d9b7e8ae 100644 --- a/tasks/composer.js +++ b/tasks/composer.js @@ -11,7 +11,15 @@ module.exports = function(grunt) { grunt.loadNpmTasks('grunt-composer'); var Help = require('../lib/help')(grunt); - grunt.config(['composer', 'install'], {}); + grunt.config(['composer', 'install'], { + options: { + flags: [ + 'no-interaction', + 'no-progress', + 'prefer-dist' + ], + } + }); Help.add({ task: 'composer', From b9a2ddd9dbeac0361e3b23eb29e9780d2a85a8a9 Mon Sep 17 00:00:00 2001 From: Grayside Date: Wed, 30 Mar 2016 12:33:29 -0700 Subject: [PATCH 2/3] Fixed windows fallback to copy:tembuild never getting called. --- tasks/make.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/make.js b/tasks/make.js index 4f501b96..bed2ac7e 100644 --- a/tasks/make.js +++ b/tasks/make.js @@ -57,7 +57,7 @@ module.exports = function(grunt) { 'clean:temp', 'drush:make', 'clean:default', - gdt.canRsync ? 'rsync:tempbuild' : 'copy:tempbuild', + gdt.canRsync() ? 'rsync:tempbuild' : 'copy:tempbuild', 'clean:temp' ] } From 039f94d9fb2830bed1858c6566c9f649950d5f45 Mon Sep 17 00:00:00 2001 From: Joe Turgeon Date: Fri, 1 Apr 2016 18:48:23 -0500 Subject: [PATCH 3/3] Fixing undefined error related to the implied options argument for canRsync. --- lib/util.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/util.js b/lib/util.js index 246ad56c..0e3aa0b7 100644 --- a/lib/util.js +++ b/lib/util.js @@ -8,9 +8,9 @@ module.exports = { return baseUrl + value; }); }, - canRsync: function() { + canRsync: function(options) { // Enable process.platform to be mocked in options for testing. - var platform = options.platform || process.platform; + var platform = options && options.platform ? options.platform : process.platform; return platform !== "win32"; } };