Skip to content

fix: service account token creation bug #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nimish-ks wants to merge 1 commit into from
+2 −2
Closed

fix: service account token creation bug #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/api/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def create(self, *args, **kwargs):
raise ValueError("Cannot add more service tokens to this app.")
return super().create(*args, **kwargs)


# Deprecated Legacy App-linked Service Tokens
class ServiceToken(models.Model):
id = models.TextField(default=uuid4, primary_key=True, editable=False)
app = models.ForeignKey(App, on_delete=models.CASCADE)
Expand Down Expand Up @@ -569,7 +569,7 @@ class ServiceAccountToken(models.Model):
created_at = models.DateTimeField(auto_now_add=True, blank=True, null=True)
updated_at = models.DateTimeField(auto_now=True)
deleted_at = models.DateTimeField(blank=True, null=True)
expires_at = models.DateTimeField(null=True)
expires_at = models.DateTimeField(null=True, blank=True)

def clean(self):
# Ensure only one of created_by or created_by_service_account is set
Expand Down