Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 36 lines occurring 2 times in 2 files: VertexShakeA.cs, VertexShakeB.cs #3

Open
phelow opened this issue Jun 2, 2019 · 1 comment

Comments

@phelow
Copy link
Owner

commented Jun 2, 2019

I've selected for refactoring 36 lines of code which are duplicated in 2 file(s) ([1](https://github.com/phelow/ithriveGameJam/blob/ffcb2eb81fbba9ec9e0780b797ca0065344454fa/Assets/TextMesh Pro/Examples/Scripts/VertexShakeA.cs#L16-L103), [2](https://github.com/phelow/ithriveGameJam/blob/ffcb2eb81fbba9ec9e0780b797ca0065344454fa/Assets/TextMesh Pro/Examples/Scripts/VertexShakeB.cs#L15-L102)). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Do not copy code.
  • Why
    When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
  • How 🔧
    Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals () when it's enough! 🏁


Good luck and happy coding! :shipit: 💯

@issue-label-bot

This comment has been minimized.

Copy link

commented Jun 2, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.69. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.