Permalink
Browse files

⚠️ Remove react-hot-loader from bundler-webpack and renderer-react

  • Loading branch information...
MoOx committed Nov 26, 2018
1 parent 9d02a0a commit e268c6adf3851d785b507f6588175d81af4720c6

This file was deleted.

Oops, something went wrong.
@@ -32,7 +32,6 @@
"extract-text-webpack-plugin": "^3.0.0",
"find-cache-dir": "^0.1.1",
"multili": "^1.1.0",
"react-hot-loader": "^3.0.0-beta.7",
"source-map-support": "^0.4.0",
"style-loader": "^0.16.1",
"webpack": "^3.0.0",
@@ -22,7 +22,6 @@ Please use an object like this:
entry: {
"phenomic.main": [
process.env.PHENOMIC_ENV !== "static" && require.resolve("webpack-hot-middleware/client"),
process.env.PHENOMIC_ENV !== "static" && require.resolve("react-hot-loader/patch"),
"./App.js"
].filter(item => item),
}
@@ -39,7 +38,6 @@ Please use an object like this:
entry: {
"phenomic.main": [
process.env.PHENOMIC_ENV !== "static" && require.resolve("webpack-hot-middleware/client"),
process.env.PHENOMIC_ENV !== "static" && require.resolve("react-hot-loader/patch"),
"./App.js"
].filter(item => item),
}
@@ -21,7 +21,6 @@ export default (webpackConfig: Object, config: PhenomicConfig) => {
// be careful about the indentation here
let adviceCode = `[
process.env.PHENOMIC_ENV !== "static" && require.resolve("webpack-hot-middleware/client"),
process.env.PHENOMIC_ENV !== "static" && require.resolve("react-hot-loader/patch"),
"./App.js"
].filter(item => item)`;
const type = typeOf(webpackConfig.entry);
@@ -11,8 +11,6 @@ module.exports = (config: PhenomicConfig) => ({
[config.bundleName]: [
process.env.PHENOMIC_ENV !== "static" &&
require.resolve("webpack-hot-middleware/client"),
process.env.PHENOMIC_ENV !== "static" &&
require.resolve("react-hot-loader/patch"),
path.join(config.path, "App.js"),
].filter(item => item),
},
@@ -40,7 +38,6 @@ module.exports = (config: PhenomicConfig) => ({
options: {
babelrc: false,
presets: [require.resolve("@phenomic/babel-preset")],
plugins: [require.resolve("react-hot-loader/babel")],
},
},
{
@@ -31,7 +31,6 @@
"debug": "^2.6.0",
"hoist-non-react-statics": "^2.5.0",
"prop-types": "^15.5.8",
"react-hot-loader": "^3.0.0-beta.7",
"socket.io-client": "^1.7.2",
"striptags": "^2.0.0",
"url-join": "^2.0.2"
@@ -2,7 +2,6 @@

import * as React from "react";
import ReactDOM from "react-dom";
import { AppContainer } from "react-hot-loader";

import Provider from "./components/Provider";
import createStore from "./shared/store";
@@ -44,13 +43,7 @@ export const renderApp = (
document.body.appendChild(root);
}

render(
<AppContainer>
<Provider store={store}>{routes()}</Provider>
</AppContainer>,
root,
callback,
);
render(<Provider store={store}>{routes()}</Provider>, root, callback);
};

export default (
@@ -34,8 +34,7 @@ if (module.hot) {
}
```

`@phenomic/plugin-bundler-webpack` and `@phenomic/plugin-renderer-react` have
`react-hot-loader@3.x` requirements so everything should works like a charm.
This will re-render your app as soon as an update in your code is received.

---

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.

0 comments on commit e268c6a

Please sign in to comment.