New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue Plugin/preset/example #1145

Open
ankitrg opened this Issue Aug 21, 2017 · 29 comments

Comments

Projects
None yet
9 participants
@ankitrg

ankitrg commented Aug 21, 2017

I would like to use Phenomic with Vue.js, has there been any effort on this front? Is there a branch or a guide on how someone can go about doing this? I would like to contribute if I can in some way.

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Aug 21, 2017

Member

No effort has been made yet from what I know.
There is no branch yet and docs for internals are not to be done.
I guess it's a nice moment to think about it.

What need to be done:

I don't know vuejs (yet) but I am very interested to have this for final 1.0.0!

Most up to date branch is the 1.0.0-alpha.6.
I guess I should use master branch instead of this kind of PR but at the same time I am hesitating since it's not helping to quickly view what has been released and what is not.
Maybe a master (stable/released) and a dev branch could do it.

You will need yarn to be able to setup the monorepo. Just clone the repo, cut a branch from 1.0.0-alpha.6 and do yarn. It should setup everything needed for you to have the project fully working. You can probably even use npm test or yarn run test to see all the test executed:

  • required transpilation
  • unit tests
  • examples builded
  • docs builded

If you want to play with an example, you can create an example from other, replace the preset in the config by a list of plugins (with your newly created plugin) and play with.

You can use the watcher for transpilation via npm run watch or yarn run watch.

If you have any questions or comments, you can continue here, and/or use our chat https://gitter.im/MoOx/phenomic

Looking forward to your contribution!

Member

MoOx commented Aug 21, 2017

No effort has been made yet from what I know.
There is no branch yet and docs for internals are not to be done.
I guess it's a nice moment to think about it.

What need to be done:

I don't know vuejs (yet) but I am very interested to have this for final 1.0.0!

Most up to date branch is the 1.0.0-alpha.6.
I guess I should use master branch instead of this kind of PR but at the same time I am hesitating since it's not helping to quickly view what has been released and what is not.
Maybe a master (stable/released) and a dev branch could do it.

You will need yarn to be able to setup the monorepo. Just clone the repo, cut a branch from 1.0.0-alpha.6 and do yarn. It should setup everything needed for you to have the project fully working. You can probably even use npm test or yarn run test to see all the test executed:

  • required transpilation
  • unit tests
  • examples builded
  • docs builded

If you want to play with an example, you can create an example from other, replace the preset in the config by a list of plugins (with your newly created plugin) and play with.

You can use the watcher for transpilation via npm run watch or yarn run watch.

If you have any questions or comments, you can continue here, and/or use our chat https://gitter.im/MoOx/phenomic

Looking forward to your contribution!

@MoOx MoOx changed the title from How do setup Phenomic to work with Vue? to Vue renderer plugin Aug 21, 2017

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Aug 25, 2017

Member

If you need anything, let us know!

Member

MoOx commented Aug 25, 2017

If you need anything, let us know!

@ankitsinghaniyaz

This comment has been minimized.

Show comment
Hide comment
@ankitsinghaniyaz

ankitsinghaniyaz Aug 25, 2017

@MoOx I forked the code and I am seeing how the React renderer is implemented. I'll come back to you if I'm in need of something.

ankitsinghaniyaz commented Aug 25, 2017

@MoOx I forked the code and I am seeing how the React renderer is implemented. I'll come back to you if I'm in need of something.

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Aug 25, 2017

Member

I made some minor changes yesterday on alpha 6 branch. Code should be a bit more clear (less confusion) maybe :)

Member

MoOx commented Aug 25, 2017

I made some minor changes yesterday on alpha 6 branch. Code should be a bit more clear (less confusion) maybe :)

@ankitsinghaniyaz

This comment has been minimized.

Show comment
Hide comment
@ankitsinghaniyaz

ankitsinghaniyaz Aug 25, 2017

Sure, I'll check it out.

ankitsinghaniyaz commented Aug 25, 2017

Sure, I'll check it out.

@MoOx MoOx changed the title from Vue renderer plugin to Vue Plugin/preset/example Aug 31, 2017

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Aug 31, 2017

Member

Do you need any help?

Member

MoOx commented Aug 31, 2017

Do you need any help?

@MoOx MoOx added the wip label Aug 31, 2017

@marioacc

This comment has been minimized.

Show comment
Hide comment
@marioacc

marioacc Sep 5, 2017

Is there something I could help?

marioacc commented Sep 5, 2017

Is there something I could help?

@sbaidon

This comment has been minimized.

Show comment
Hide comment
@sbaidon

sbaidon Sep 5, 2017

I would love to help as well if possible! 👍

sbaidon commented Sep 5, 2017

I would love to help as well if possible! 👍

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Sep 5, 2017

Member

@ankitsinghaniyaz @ankitrg @marioacc @sbaidon if you want I can all give you write access to the repo so you can work together on a branch. Who is interested?

Member

MoOx commented Sep 5, 2017

@ankitsinghaniyaz @ankitrg @marioacc @sbaidon if you want I can all give you write access to the repo so you can work together on a branch. Who is interested?

@sbaidon

This comment has been minimized.

Show comment
Hide comment
@sbaidon

sbaidon Sep 5, 2017

I would be up for it, I just need a bit of guidance

sbaidon commented Sep 5, 2017

I would be up for it, I just need a bit of guidance

@ankitrg

This comment has been minimized.

Show comment
Hide comment
@ankitrg

ankitrg Sep 6, 2017

Yes @sbaidon , I agree a little walkthrough would be good enough.

ankitrg commented Sep 6, 2017

Yes @sbaidon , I agree a little walkthrough would be good enough.

@marioacc

This comment has been minimized.

Show comment
Hide comment
@marioacc

marioacc Sep 6, 2017

I am interested, but as well I need a walkthrough 😄

marioacc commented Sep 6, 2017

I am interested, but as well I need a walkthrough 😄

@marioacc

This comment has been minimized.

Show comment
Hide comment
@marioacc

marioacc Sep 11, 2017

@MoOx, Is the proposal still available?

marioacc commented Sep 11, 2017

@MoOx, Is the proposal still available?

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Sep 13, 2017

Member

Yeah sure. Feel free to use this issue to discuss about what you need or with our chat http://gitter.im/phenomic/phenomic.
Check out the CONTRIBUTING.md and what https://github.com/phenomic/phenomic/tree/master/packages/plugin-renderer-react is exporting. You can also check

getRoutes?: Function,
renderStatic?: PhenomicPluginRenderStaticType,
renderDevServer?: PhenomicPluginRenderDevServerType,

Also be sure to talk to each others to not start working on the same thing. I am adding all of you to the repo!

@ankitsinghaniyaz Did you start something? @ankitrg You have a very similar name to @ankitsinghaniyaz so I am curious, are you the same person?

Member

MoOx commented Sep 13, 2017

Yeah sure. Feel free to use this issue to discuss about what you need or with our chat http://gitter.im/phenomic/phenomic.
Check out the CONTRIBUTING.md and what https://github.com/phenomic/phenomic/tree/master/packages/plugin-renderer-react is exporting. You can also check

getRoutes?: Function,
renderStatic?: PhenomicPluginRenderStaticType,
renderDevServer?: PhenomicPluginRenderDevServerType,

Also be sure to talk to each others to not start working on the same thing. I am adding all of you to the repo!

@ankitsinghaniyaz Did you start something? @ankitrg You have a very similar name to @ankitsinghaniyaz so I am curious, are you the same person?

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Sep 13, 2017

Member

Btw, if you need some changes to the current API, do not hesitate to discuss about it, we are open!

Member

MoOx commented Sep 13, 2017

Btw, if you need some changes to the current API, do not hesitate to discuss about it, we are open!

@ankitsinghaniyaz

This comment has been minimized.

Show comment
Hide comment
@ankitsinghaniyaz

ankitsinghaniyaz Sep 16, 2017

@MoOx Yes, they both are my profile I use two profiles for some reason. I'll correspond here with this profile. I haven't got a chance to spend time on the codebase. I looked into the render and how it works, but it seems I have to put in some more effort to understand it better.

ankitsinghaniyaz commented Sep 16, 2017

@MoOx Yes, they both are my profile I use two profiles for some reason. I'll correspond here with this profile. I haven't got a chance to spend time on the codebase. I looked into the render and how it works, but it seems I have to put in some more effort to understand it better.

@MoOx MoOx added the Hacktoberfest label Sep 28, 2017

@sicavalentine

This comment has been minimized.

Show comment
Hide comment
@sicavalentine

sicavalentine Sep 29, 2017

I have 2+ years experience with both React and Vuejs and can help if needed :D

sicavalentine commented Sep 29, 2017

I have 2+ years experience with both React and Vuejs and can help if needed :D

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Oct 2, 2017

Member

I am going to write a doc on what phenomic expects, that might help you :)

Member

MoOx commented Oct 2, 2017

I am going to write a doc on what phenomic expects, that might help you :)

@nathanchere

This comment has been minimized.

Show comment
Hide comment
@nathanchere

nathanchere Nov 8, 2017

Is anyone actively working on this before I start on it?

nathanchere commented Nov 8, 2017

Is anyone actively working on this before I start on it?

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Nov 9, 2017

Member

Nobody yet from what I know

Member

MoOx commented Nov 9, 2017

Nobody yet from what I know

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Nov 9, 2017

Member

@nathanchere tell me if you want to work on this, I can add you as a collab for the repo

Member

MoOx commented Nov 9, 2017

@nathanchere tell me if you want to work on this, I can add you as a collab for the repo

@ankitsinghaniyaz

This comment has been minimized.

Show comment
Hide comment
@ankitsinghaniyaz

ankitsinghaniyaz Nov 19, 2017

I've some time now and I would like to start again. @MoOx I just had the question will there be two different plugins for Vue and Nuxt? Just like React and Next?

ankitsinghaniyaz commented Nov 19, 2017

I've some time now and I would like to start again. @MoOx I just had the question will there be two different plugins for Vue and Nuxt? Just like React and Next?

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Nov 21, 2017

Member

I am not familiar with Nuxt, but if it's hide the "build" part like Next does I guess so.

Member

MoOx commented Nov 21, 2017

I am not familiar with Nuxt, but if it's hide the "build" part like Next does I guess so.

@MoOx MoOx removed the Hacktoberfest label Dec 2, 2017

@MoOx MoOx added the plugin label May 4, 2018

@mandaputtra

This comment has been minimized.

Show comment
Hide comment
@mandaputtra

mandaputtra Aug 28, 2018

Still open? I would like to help

mandaputtra commented Aug 28, 2018

Still open? I would like to help

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Aug 29, 2018

Member

You can help. It's still open indeed. Note that I am AFK this days that's why project is not moving :) (will probably be back in September)

Member

MoOx commented Aug 29, 2018

You can help. It's still open indeed. Note that I am AFK this days that's why project is not moving :) (will probably be back in September)

@mandaputtra

This comment has been minimized.

Show comment
Hide comment
@mandaputtra

mandaputtra Aug 30, 2018

okay, please guide me, I will fork first. Anyone in this project, please contact me to work together

mandaputtra commented Aug 30, 2018

okay, please guide me, I will fork first. Anyone in this project, please contact me to work together

@medfreeman

This comment has been minimized.

Show comment
Hide comment
@medfreeman

medfreeman Sep 3, 2018

Contributor

i'm also interested in this, but for Nuxt.js.
i wonder if vue and nuxt plugins will share code somehow.
btw, i'm in the process of finishing remark-vue, so markdown can be compiled safely to vue (it needs a few contributions to hast-to-hyperscript before reaching a stable stage).
I'll also probably transform this to a monorepo (want to try lerna), with a second rehype-vue package, in order to be more in-line with what's done in @phenomic/helpers-transform

Contributor

medfreeman commented Sep 3, 2018

i'm also interested in this, but for Nuxt.js.
i wonder if vue and nuxt plugins will share code somehow.
btw, i'm in the process of finishing remark-vue, so markdown can be compiled safely to vue (it needs a few contributions to hast-to-hyperscript before reaching a stable stage).
I'll also probably transform this to a monorepo (want to try lerna), with a second rehype-vue package, in order to be more in-line with what's done in @phenomic/helpers-transform

@mandaputtra

This comment has been minimized.

Show comment
Hide comment
@mandaputtra

mandaputtra Sep 4, 2018

@medfreeman interesting, what issue i can help?

mandaputtra commented Sep 4, 2018

@medfreeman interesting, what issue i can help?

@medfreeman

This comment has been minimized.

Show comment
Hide comment
@medfreeman

medfreeman Sep 5, 2018

Contributor

@mandaputtra
concerning remark-vue, i only need to finish writing tests for hast-to-hyperscript, wait for merge and release a new version.
Then publishing rehype-vue, which should basically be the same without a few lines of code doing basically what remark-rehype does.
then figuring / asking how to extend the unified processor to use this module, and removing rehype-react.

concerning a phenomic-nuxt plugin, that would probably be, as for next.js, a combination of a renderer and a bundler plugin, since nuxt takes care of both of these.
@phenomic/plugin-bundler-renderer-nuxt

The first part should be what will be of use to both of the vue and nuxt plugins.
Then, if nuxt inherits some things about routes formats, app tree decoration or smth from vue, we'll probably have to share some code in a helper package.

Contributor

medfreeman commented Sep 5, 2018

@mandaputtra
concerning remark-vue, i only need to finish writing tests for hast-to-hyperscript, wait for merge and release a new version.
Then publishing rehype-vue, which should basically be the same without a few lines of code doing basically what remark-rehype does.
then figuring / asking how to extend the unified processor to use this module, and removing rehype-react.

concerning a phenomic-nuxt plugin, that would probably be, as for next.js, a combination of a renderer and a bundler plugin, since nuxt takes care of both of these.
@phenomic/plugin-bundler-renderer-nuxt

The first part should be what will be of use to both of the vue and nuxt plugins.
Then, if nuxt inherits some things about routes formats, app tree decoration or smth from vue, we'll probably have to share some code in a helper package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment