Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack@2 introduced a breaking change between beta22 & beta23 #767

Closed
MoOx opened this Issue Sep 20, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@MoOx
Copy link
Member

MoOx commented Sep 20, 2016

Basically all configuration for eslint-loader, postcss-loader, sass-loader need to be moved out of webpack config as it's validated AND THROW ERRORS. Well... Fuck semver.

"Official" solution is to move those options into a loader plugin call...

webpack/webpack#2974 (comment)

You can say "no big deal man". But seriously, all of this because in the first place query can't handle some real JS (in a js file, that's funny right?)

This solution is not acceptable for me with my current mood as everybody will have to update more of their code. So I am not ready to cut a release with this dawn change and it's blocking us for a major release. I am pissed off, sorry for that.

Tell me what you think about the "official" solution (it's more a poor "workaround" to me)...

@DavidWells

This comment has been minimized.

Copy link
Member

DavidWells commented Sep 20, 2016

O no!

@MoOx MoOx changed the title F***: webpack@2 introduced a breaking change between beta22 & beta23 webpack@2 introduced a breaking change between beta22 & beta23 Sep 20, 2016

@MoOx MoOx added bug and removed discussion labels Sep 20, 2016

@MoOx

This comment has been minimized.

Copy link
Member Author

MoOx commented Sep 20, 2016

Ok this has not been clear but it seems that query accept any JS now. This will do the trick.
Also what will need to be done:

  • remove makeConfig (webpack 2 support directly a function)
  • replace "loaders" by "rules"
  • replace custom key by query directly
@thangngoc89

This comment has been minimized.

Copy link
Contributor

thangngoc89 commented Sep 20, 2016

Oh craps. This release takes forever.

@MoOx

This comment has been minimized.

Copy link
Member Author

MoOx commented Sep 20, 2016

This release takes forever.

This is for the better ;)

@thangngoc89

This comment has been minimized.

Copy link
Contributor

thangngoc89 commented Sep 20, 2016

replace "loaders" by "rules"

What is this?

@MoOx

This comment has been minimized.

Copy link
Member Author

MoOx commented Sep 20, 2016

just renaming "loaders" by "rules" in webpack.module section ( so module.loaders => modules.rules)

@thangngoc89

This comment has been minimized.

Copy link
Contributor

thangngoc89 commented Sep 20, 2016

I like that changes. It's confused as hell when I worked on the loader configuration transformer

@MoOx MoOx removed the blocked label Sep 21, 2016

@MoOx

This comment has been minimized.

Copy link
Member Author

MoOx commented Sep 21, 2016

Fixed (kind of) in 7ca3cb1

@MoOx MoOx closed this Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.