New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT-3708: Automatic layout may leave pedigree in an un-saveable un-exportable state #2658

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
4 participants
@allasm
Member

allasm commented Jun 4, 2018

@sashaandjic talk with me about testing

@allasm allasm requested a review from veronikaslc Jun 4, 2018

@sashaandjic

This comment has been minimized.

Show comment
Hide comment
@sashaandjic

sashaandjic Jun 5, 2018

Problem found.

  1. Create new patient; open pedigree with a single node template; add diagnosis, phenotype, gene and cancer
  2. Unlink patient and uncheck Clear data for this individual
  3. Click on the node; click on New bttn to create patient for the node
  4. Create a sibling
  5. Assign "hanging" family member to a sibling node
  6. clink on Undo bttn until you go to the begining (one blank node)
  7. Click Redo bttn 4 times to get diagnosis, phenotype, gene and cancer (as in Step 1)
  8. Click Redo bttn again (to unlink patient from node as in Step 2)
  9. Click Redo bttn again (to create new patient record as in Step 3; notice that phenotype, genotype and diagnosis are replaced with "affected")
  10. Click Redo again ( sibling created as in Step 4)
  11. Click Redo again ( to assign the "hanging" member to a sibling node as in Step 5)

step 1 - one node with disease phenotype genotype and cancer

step 2 - unlink

step 3 - create new patient

step 4 - add sibling

step 5 - assign family member

redo 1-2-3-4

redo 5 - unlink

redo 6 - create new

redo 7 - add sibling

redo 8 - assign family memebr

sashaandjic commented Jun 5, 2018

Problem found.

  1. Create new patient; open pedigree with a single node template; add diagnosis, phenotype, gene and cancer
  2. Unlink patient and uncheck Clear data for this individual
  3. Click on the node; click on New bttn to create patient for the node
  4. Create a sibling
  5. Assign "hanging" family member to a sibling node
  6. clink on Undo bttn until you go to the begining (one blank node)
  7. Click Redo bttn 4 times to get diagnosis, phenotype, gene and cancer (as in Step 1)
  8. Click Redo bttn again (to unlink patient from node as in Step 2)
  9. Click Redo bttn again (to create new patient record as in Step 3; notice that phenotype, genotype and diagnosis are replaced with "affected")
  10. Click Redo again ( sibling created as in Step 4)
  11. Click Redo again ( to assign the "hanging" member to a sibling node as in Step 5)

step 1 - one node with disease phenotype genotype and cancer

step 2 - unlink

step 3 - create new patient

step 4 - add sibling

step 5 - assign family member

redo 1-2-3-4

redo 5 - unlink

redo 6 - create new

redo 7 - add sibling

redo 8 - assign family memebr

@sdumitriu

This comment has been minimized.

Show comment
Hide comment
@sdumitriu

sdumitriu Jun 6, 2018

Member

@sashaandjic Is that problem introduced by this pull request? If not, since "automatic layout" is not used in your procedure, it is completely unrelated and should be filed as a separate bug.

Member

sdumitriu commented Jun 6, 2018

@sashaandjic Is that problem introduced by this pull request? If not, since "automatic layout" is not used in your procedure, it is completely unrelated and should be filed as a separate bug.

@allasm allasm changed the base branch from master to pedigree-14rc1 Jun 6, 2018

@allasm allasm merged commit b096a70 into pedigree-14rc1 Jun 6, 2018

1 check was pending

jenkins Build started sha1 is merged.
Details

@allasm allasm deleted the PT-3708 branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment