atom position off in game

[jbphet]

I'm regression testing master after pulling in some things from the 1.4-phetio branch, and saw a problem in the game where the position of an atom was off, see screenshot below. This should be fixed before next release off of master that includes the game.

[jbphet]

Here's another somewhat similar case that I ran into:

[phet-steele]

@jessegreenberg @jbphet this did not get fixed before the release of 1.6.0-rc.1. JB decided Jesse should fix it. For phetsims/qa/issues/22.

[jessegreenberg]

Thanks @phet-steele, shutting down the RC until this is added.

[jessegreenberg]

Layout fixed in the above commit, layout was changed so that it looks like the published version.

[phet-steele]

@jessegreenberg, the atoms in every game look to be correctly vertically aligned on the screen, but not horizontally. Between different challenges, you can see an atom jump left and right with respect to each other. Below, the atom for Helium is much more to the left:

[jessegreenberg]

@phet-steele do you know if the deployed version exhibits any of this atom jumping?

[phet-steele]

@phet-steele do you know if the deployed version exhibits any of this atom jumping?

It does.

[jbphet]

IMO, this is still worth fixing even if it appears in the published version unless it is unexpectedly difficult to do so.

[jessegreenberg]

@jbphet sounds good.

The atom is placed relative to its center, and the stability indicator for a particular AtomNode will change its bounds:

If we place the atom according to its left bound, things should align.

[jessegreenberg]

Handled in the above commit. Seemed to fix it, and I verified that the other AtomNodes in the other game views don't have this problem.

[phet-steele]

I LIKE it!