Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the wire body doesn't appear in the toolbox #124

Closed
samreid opened this issue Jul 31, 2017 · 7 comments
Closed

Sometimes the wire body doesn't appear in the toolbox #124

samreid opened this issue Jul 31, 2017 · 7 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jul 31, 2017

I've seen this twice now. Last sighting was in requirejs (not sure where 1st sighting was).

This is Mac/Chrome on current master:

image

@jonathanolson any guesses what might be happening here?

@jonathanolson
Copy link
Contributor

Might be related to image loading.

Will want to inspect a case where this has happened, or have reproduction instructions (can't reproduce locally).

@samreid
Copy link
Member Author

samreid commented Jul 31, 2017

I refreshed 15 times and haven't seen it again yet.

samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 31, 2017
@samreid
Copy link
Member Author

samreid commented Jul 31, 2017

@samreid
Copy link
Member Author

samreid commented Jul 31, 2017

@phet-steele tested it out and we decided we like this fix. Closing.

@phet-steele
Copy link
Contributor

@samreid, looked again and the fix doesn't handle switching to schematic view. The non-schematic wire is always shown in the carousel.

@phet-steele phet-steele reopened this Jul 31, 2017
@phet-steele phet-steele assigned samreid and unassigned jonathanolson Jul 31, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Aug 1, 2017
@samreid
Copy link
Member Author

samreid commented Aug 1, 2017

@phet-steele
Copy link
Contributor

Second time's the charm! (right?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants