Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a stable version for AAPT #76

Closed
samreid opened this issue Jul 17, 2017 · 18 comments
Closed

Prepare a stable version for AAPT #76

samreid opened this issue Jul 17, 2017 · 18 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jul 17, 2017

@kathy-phet could use a stable version for AAPT next week.

@samreid samreid self-assigned this Jul 17, 2017
@samreid
Copy link
Member Author

samreid commented Jul 17, 2017

I published a dev version here: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.80/circuit-construction-kit-dc_en.html

Here is a snapshot of the known open issues on my radar:
image

@arouinfar @ariel-phet @kathy-phet can you please do some brief sanity testing so we can determine whether this is stable enough for AAPT?

@samreid
Copy link
Member Author

samreid commented Jul 17, 2017

I tested for about 5 minutes on Chrome and noted 3 new issues (none are necessarily deal-breakers).

@samreid samreid removed their assignment Jul 17, 2017
@arouinfar
Copy link
Contributor

@samreid I was using dev.79 earlier today and encountered two deal-breaking issues

  • After awhile the carousel becomes inactive. Components cannot be taken out or returned, and it requires a browser refresh to fix.
  • At some point, the cut button stopped working (carousel was still ok). Also required browser refresh to fix.

I don't know if these were known issues that were fixed in dev.80, but I wanted to point them out. I will test dev.80 and see if I can reproduce the above issues.

@samreid
Copy link
Member Author

samreid commented Jul 17, 2017

dev.80 is pretty similar to dev.79, I bet the same issues are there. Please double check and create issues.

UPDATE: Please also report your OS and Browser in case it correlates with the problem.

@arouinfar
Copy link
Contributor

Will do @samreid.

@arouinfar
Copy link
Contributor

I've finished testing dev.80 @samreid. I'm still unable to reproduce the freezing carousel. @phet-steele has also tried, but hasn't (yet) reproduced it. It happened in 3 interviews (1 on iPad Air/Safari, 2 on Mac/Chrome). After the students used the sim for awhile, the carousel became unresponsive. Items couldn't be returned or taken out of it, and the browser had to be refreshed to fix the problem.

@arouinfar arouinfar removed their assignment Jul 18, 2017
@samreid
Copy link
Member Author

samreid commented Jul 18, 2017

I'm glad to hear interviews were performed on dev.80. Do you know how long the sim was used before going unresponsive? Also, did you learn anything else from the interviews that will inform the design or implementation?

@arouinfar
Copy link
Contributor

@samreid sorry, I was a bit unclear. The interviews were done on dev.77 (Mac/Chrome), dev.78 (iPad Air/Safari), and dev.79 (Mac/Chrome). I was conducting interviews on Projectile Motion, and there was enough time at the end to let them use CCK:DC, as well.

I'm still reviewing the footage and making some notes, but I won't have any major change requests based on this round of interviews.

@samreid
Copy link
Member Author

samreid commented Jul 18, 2017

OK thanks for clarifying!

@samreid samreid assigned samreid and unassigned arouinfar Jul 18, 2017
@samreid
Copy link
Member Author

samreid commented Jul 19, 2017

It sounds like the light bulb ghosting was the only blocking issue and there is a proposed fix for that in phetsims/circuit-construction-kit-common#388

Perhaps we should continue testing in http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.83/circuit-construction-kit-dc_en.html

But there have been a number of other commits since then, so this is not really a "stable sha"
image

@samreid
Copy link
Member Author

samreid commented Jul 20, 2017

Version dev.85 fixes the carousel lock-up bug:
http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.85/circuit-construction-kit-dc_en.html . Let's continue testing this one.

@samreid
Copy link
Member Author

samreid commented Jul 20, 2017

Tagging for design meeting so we can come up with a plan to make sure something is OK for AAPT.

@samreid
Copy link
Member Author

samreid commented Jul 20, 2017

@samreid
Copy link
Member Author

samreid commented Jul 20, 2017

Electron opacity is restored, will be ready in next version.

@samreid
Copy link
Member Author

samreid commented Jul 20, 2017

I published http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.87/circuit-construction-kit-dc_en.html

This has electron opacity, fixes the 0.0 battery readout, fixes the broken cut button, and fixes the mouse and pointer areas for schematic items.

@arouinfar @ariel-phet @phet-steele can you please test this? Should I create a QA issue?

@samreid
Copy link
Member Author

samreid commented Jul 20, 2017

I went ahead and created a QA issue: phetsims/qa#26

@samreid samreid removed their assignment Jul 20, 2017
@arouinfar
Copy link
Contributor

arouinfar commented Jul 21, 2017

@phet-steele and I think dev.91 will be good to go at AAPT.

@kathy-phet there are a few caveats

@ariel-phet
Copy link

Considering @samreid emailed @kathy-phet about this version with caveats and she has given her presentation, we can close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants