Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string literals with enumerations #146

Open
pixelzoom opened this issue Sep 14, 2023 · 1 comment
Open

Replace string literals with enumerations #146

pixelzoom opened this issue Sep 14, 2023 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

Use StringEnumerationProperty or EnumerationProperty for the Properties shown below. This should be done before publishing a PhET-iO version.

// ColorVisionModel

    this.headModeProperty = new StringProperty( 'no-brain', {
      validValues: [ 'brain', 'no-brain' ],
      tandem: tandem.createTandem( 'headModeProperty' )
    } );

// SingleBulbModel

    this.lightTypeProperty = new StringProperty( 'colored', {
      validValues: [ 'white', 'colored' ],
      tandem: tandem.createTandem( 'lightTypeProperty' )
    } );

    // @public {Property.<string>} indicates solid beam vs individual photons
    this.beamTypeProperty = new StringProperty( 'beam', {
      validValues: [ 'beam', 'photon' ],
      tandem: tandem.createTandem( 'beamTypeProperty' )
    } );
@Luisav1
Copy link
Contributor

Luisav1 commented Apr 29, 2024

Deferring this issue since we're not going to republish with PhET-iO for the upcoming publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants