Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard dialog missing #155

Open
Tracked by #1145
Nancy-Salpepi opened this issue Aug 12, 2024 · 2 comments
Open
Tracked by #1145

Keyboard dialog missing #155

Nancy-Salpepi opened this issue Aug 12, 2024 · 2 comments
Assignees
@marlitas @Nancy-Salpepi
Labels
dev:alt-input status:ready-for-review

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#1115 since this sim has alt input shouldn't there be a keyboard dialog?
Luisav1 added a commit that referenced this issue Aug 21, 2024
@Luisav1
Create and add keyboard dialog. #155.
6913236
@Luisav1
Copy link
Contributor

Luisav1 commented Aug 21, 2024

Thanks @Nancy-Salpepi! I've added a keyboard dialog.

@amanda-phet, would you like to take a look at this too? I’ve assigned it to you just in case.

@Luisav1 Luisav1 assigned amanda-phet and unassigned Luisav1 Aug 21, 2024
@amanda-phet
Copy link
Contributor

It looks like it has everything included! Looks good to me.

@marlitas marlitas assigned marlitas and unassigned Luisav1 Sep 9, 2024
@marlitas marlitas mentioned this issue Sep 19, 2024
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

@Nancy-Salpepi Nancy-Salpepi

Labels
dev:alt-input status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amanda-phet @marlitas @Luisav1 @Nancy-Salpepi