From 09f4897d343524f2fc0572dc919d5399e5c64bbc Mon Sep 17 00:00:00 2001 From: Jesse Date: Wed, 22 Apr 2020 11:29:24 -0400 Subject: [PATCH] Attach the Display KeyStateTracker to body, don't update in PDOMPointer, see phetsims/scenery#1048 --- js/display/Display.js | 1 + js/input/PDOMPointer.js | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/js/display/Display.js b/js/display/Display.js index 2a3ae604b..646b3c294 100644 --- a/js/display/Display.js +++ b/js/display/Display.js @@ -1902,6 +1902,7 @@ Display.userGestureEmitter = new Emitter(); // @public (read-only) {KeyStateTracker} - A global object that tracks the state of the keyboard for all Displays. Use this // to get information about which keyboard keys are pressed down and for how long. Display.keyStateTracker = new KeyStateTracker(); +Display.keyStateTracker.attachToBody(); /** * Returns true when NO nodes in the subtree are disposed. diff --git a/js/input/PDOMPointer.js b/js/input/PDOMPointer.js index da9e6830e..4047c9a47 100644 --- a/js/input/PDOMPointer.js +++ b/js/input/PDOMPointer.js @@ -66,7 +66,6 @@ class PDOMPointer extends Pointer { if ( this.blockTrustedEvents && event.domEvent.isTrusted ) { return; } - Display.keyStateTracker.keydownUpdate( event.domEvent ); // set the target to potentially block keyup events this.keydownTargetNode = event.target; @@ -75,7 +74,6 @@ class PDOMPointer extends Pointer { if ( this.blockTrustedEvents && event.domEvent.isTrusted ) { return; } - Display.keyStateTracker.keyupUpdate( event.domEvent ); // The keyup event was received on a node that didn't receive a keydown event, abort to prevent any other // listeners from being called for this event. Done after updating KeyStateTracker so that the global state