Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iPad 2] Safari on iOS 9.3.5 takes unconventional creative liberties with SVG rendering #654

Open
jonathanolson opened this issue Jul 26, 2017 · 4 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

Noted in phetsims/function-builder#35 and phetsims/projectile-motion#129.

Safari iOS appears to take an avant-garde approach clearing rectangles in SVG rendering:
35
img_0091

In toeing the more conservative "don't look crazy buggy" line, we've handled this in the past by forcing sections (usually on top) to render in Canvas instead of SVG. This may affect performance, however.

Tracking instances of this bug (and how it was solved) here.

@jonathanolson jonathanolson self-assigned this Jul 26, 2017
@jonathanolson jonathanolson changed the title [iOS] Safari on iOS 9.3.5 takes unconventional creative liberties with SVG rendering [iPad 2] Safari on iOS 9.3.5 takes unconventional creative liberties with SVG rendering Jul 26, 2017
@jonathanolson
Copy link
Contributor Author

In a fun turn of events, setting { layerSplit: true } on the projectile-motion CannonNode caused the cannon to somewhat animate with the projectile ONLY on iPad 2.

So presumably this bug can affect positioning/layout, not just clipping artifacts.

Proposed fix for projectile-motion is, again, setting something to render in Canvas.

@phet-steele
Copy link
Contributor

phetsims/balancing-act/issues/70 also falls under this issue, and has shown similar problems in projectile-motion:
img_0097
img_0097

balancing-act:

20160406_162848

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 12, 2018

A variation of this problem was noted in Equality Explorer, see phetsims/equality-explorer#135. In the Operations screen, the bottoms of the operator radio buttons disappear when an operation is applied. The relevant code is UniversalOperationControl.js. See that issue for a video demonstration. Here's a screenshot:

42240623-1c68f0d4-7ec5-11e8-9fbb-b44d3ca75df9

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Nov 8, 2018

This showed up again in coulombs-law, see #890, when the arrow buttons are disabled on the number controls, certain positions of the charges in the sim cause the arrows to be partially rendered, only in iOS 9.3.5. The problem went away with rootRenderer="canvas".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants