Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars design on LevelSelectionButtons #123

Open
marlitas opened this issue Feb 5, 2024 · 6 comments
Open

Stars design on LevelSelectionButtons #123

marlitas opened this issue Feb 5, 2024 · 6 comments

Comments

@marlitas
Copy link
Contributor

marlitas commented Feb 5, 2024

While talking through phetsims/arithmetic#174 with @catherinecarter she brought up the design of stars for reviews on online shopping sites. We noticed that they all have a similar way of outlining and filling stars in that differs from what games are currently doing.

Amazon:
image (1)
Target:
image
Walmart:
image
Ebay:
image
REI (wasn't our favorite):
image

Our sims:
image

We felt that the design being used by these online shopping sites is more aesthetically pleasing, but also easier to read. The half stars are easier to process when there is a consistent outline around all the stars than when the outline is filled in as the star gets filled in.

We would like to:

  • Use a thinner outline that is always present for all stars (perhaps a darker yellow/orange rather than black)
  • Only have an empty outline instead of greyed out stars
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 5, 2024

Stars design on LevelSelectionButtons

These stars are not specific to LevelSelectionButtons. They may also appear on the status bar for each level (FiniteStatusBar, InfiniteStatusBar) depending on how the status bar is configured, and in the dialog that is displayed when a level is completed (LevelCompletedNode).

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 5, 2024

This seems like a fine change to me, but I have concerned about the stroke used in the mockups above. I think it would be fine to have the stroke be the same for all of the stars, regardless of whether they are filled. But I would stick with a ‘black’ stroke. I don’t think there’s a lot of benefit to non-black, and many potential landmines.

Also... The current design was done over in #59 (comment). I believe @amanda-phet was involved.

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 5, 2024

Thinking about it (and playing with it) more, I’m now on the fence. I tend to agree with what @kathy-phet said in Slack#design-sims:

I think for me the stroke - because it only turns to black with the star fill helps me realize it’s only a half full.

@amanda-phet
Copy link

I don't like the idea of using a non-black outline for the stars. Our current stars fit the "toon' style of our sims quite well by using a black stroke.

I just did a quick mockup of the other suggestion. If I understand correctly, @marlitas and @catherinecarter are suggesting option B:

Only have an empty outline instead of greyed out stars

I also mocked up option C based on the slack conversation.

image

Let me know what other options you'd like to see.

@marlitas
Copy link
Contributor Author

Meeting 2/12:

  • This is not a priority, and would need student interviews to quantify the opinions here.
  • We are going to defer until larger game design conversations touch on this again.

@amanda-phet
Copy link

Our stars are most similar to Target's, so if we decide to "modernize" these stars then I would go that direction (thinner stroke and no gray fill on the unfilled stars).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants