'Pronunciation' and 'Meanings' not translated

[Moonbase59]

The headers 'Pronunciation' and 'Meanings' aren’t translated, and 'New Note' isn’t. All are in 'de.ts', for example.

[phibr0]

I currently can't check in App, could you provide Screenshots or just explain where exactly something isn't translated? As I am checking in the Code it should all be translated fine.

[Moonbase59]

Let’s take the phrases 'Pronunciation', 'Meanings' and 'New Note', which are used in the side panel and when generating a new note (for {{pronunciationHeader}} and {{meaningHeader}}).

Let’s also assume we’re using only English and German. The phrases are correct in de.ts and also make it into the plugin’s main.js:

    //dictionaryView.svelte
    'Enter a word': 'Gebe ein Wort ein',
    'Pronunciation': 'Aussprache',
    'Meanings': 'Bedeutungen',
    'New Note': 'Neue Notiz',

When setting Obsidian to German ("Deutsch"), the side panel still shows the English headings:

When I click on 'New Note', the English headings are also used in the new note:

[phibr0]

The Language is set by Obsidians internal Moment Locale. You have set your Language to German which should turn the Plugins Language to German too. Are the Settings also all in English?

[Moonbase59]

The Obsidian settings are in German, those of non-translated plugins in English, yours also in English:

Reminds me of an odd problem I had, and nobody found an answer for (I’m using the moment.js locale myself to check what language Obsidian runs in): https://forum.obsidian.md/t/new-with-0-12-4-moment-locale-sticks-at-en-even-when-i-switch-obsidian-to-another-language/19673

[Moonbase59]

Hm. If I enter

moment().locale()

in the dev console, it gives me en. So maybe related, but for the life of me I can’t make out who or what messes with moment’s locale and sets it globally …

Let me try

moment.locale("de")

and see what happens.

Still the same:

But I wonder … if it wouldn’t work in general, why then did it translate Adjective into Adjektiv (below the Meanings header)?

[phibr0]

"Adjektiv" came as part of the API Response, not from the Plugin itself. Could you maybe try to disable all Plugins except the Dictionary Plugin? Or just create a Test Vault with only that Plugin installed.

[phibr0]

Also I am pretty sure that after setting the moment locale to de the View needs to be re-rendered to show changes in these Strings.

[Moonbase59]

Yep, I’ve later seen that it came from the API. Any idea how I could re-render the view?

I’ll try the plugin disable/new vault later on.

[phibr0]

I think just closing it (right click on the icon) and opening it again with the Command should work

[Moonbase59]

Got it! After disabling all plugins except yours, …

• settings come up in German
• the side pane gets translated
• notes created have the German text*

So I must really dig in deeper to isolate the plugin that causes the locale mess-up. Sorry for bothering you with this!

• = There is one untranslated string still: In the dictionary-generated note, Pronunciation has a list item - undefined. "Undefined" should probably also be translated.

Btw, thanks for making this really useful plugin, and actually taking care of translations—not many plugins do that.

[phibr0]

The undefined actually has to be a bug, it shouldn't print "Aussprache" if it doesn't have any data for it.

I think the Calendar Plugin overrides the moment locale but I am not sure.

[Moonbase59]

Calendar: Yeah, someone mentioned that in the forums, but I’ve never used that. So there must be another miscreant ;-)

Doesn’t the note always contain all information, even if there’s nothing in it? If not, we have another minor bug.

[phibr0]

Since this isn't really a Issue of this Plugin i will close this for now. The other Plugins which are localized also get the locale from moment which is why I think it's fine like that.

[Moonbase59]

Yep. I finally found the miscreant: It was the Obsidian Pomodoro Plugin that globally set the moment locale.