Feature/partial match #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tackles issue phibr0#19 `Filter as partial match`.
|
I literally just came to this repo because I thought an emoji was missing, but it turns out it's just not easy to find because of the issue you are fixing here (the use case is the |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles issue #19
Filter as partial match.Slight improvement would be to order results in increasing order of found index, so for
:mus,:muscle:馃挭 should appear before:unamused:馃槖. Minimal gain for the effort though, probably saves 0.1s out of a users life, so decided not worth adding the extra implementation.