New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting unneeded `write protect` bit when enabling paging #47

Closed
phil-opp opened this Issue Nov 18, 2015 · 0 comments

Comments

1 participant
@phil-opp
Copy link
Owner

phil-opp commented Nov 18, 2015

Ahmed Charles noted in a comment that we set the write protect bit when enabling paging. It's bit 16 in the CR0 register, Wikipedia describes it like this:

When set, the CPU can't write to read-only pages when privilege level is 0

The question is wether we should keep it (and add an explaining comment) or remove it (since it's not required for the switch to long mode).

I think it's reasonable to set it but maybe it's better to do it in a later post when it's required. When we remove it, it must not cause problems for people with the old version.

Any opinions are appreciated :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment