Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding French translation for the first post #1053

Merged
merged 19 commits into from Oct 17, 2021

Conversation

AlexandreMarcq
Copy link
Contributor

No description provided.

@AlexandreMarcq AlexandreMarcq changed the title [WIP] Adding French translation [WIP] Adding French translation for the first post Sep 23, 2021
@AlexandreMarcq AlexandreMarcq marked this pull request as ready for review September 23, 2021 13:36
@AlexandreMarcq AlexandreMarcq changed the title [WIP] Adding French translation for the first post Adding French translation for the first post Sep 23, 2021
blog/config.toml Outdated Show resolved Hide resolved
@phil-opp
Copy link
Owner

phil-opp commented Oct 7, 2021

Hi @alekzus, thanks a lot for your work! Sorry for the late reply, I missed that you marked this as "ready for review". I don't speak French, so I cannot review this personally, but I will look for someone who can.

(If someone who speaks French is reading this: A quick review of this translation would be greatly appreciated!)

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
AlexandreMarcq and others added 2 commits October 8, 2021 08:35
….fr.md

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
….fr.md

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Copy link
Contributor

@dallenng dallenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a thorough read but managed to catch a few typos.

AlexandreMarcq and others added 3 commits October 8, 2021 22:54
@AlexandreMarcq
Copy link
Contributor Author

Thank you both for your reviews. Sorry for all the typos @dallenng, I must have been pretty tired when writing these.

+++
+++

La première étape pour créer notre propre noyau de système d'exploitation est de créer un exécutable Rust qui ne relie pas la bibliothèque standard. Cela rend possible l'exécution du code Rust sur la ["bare machine"][machine nue] sans système d'exploitation sous-jacent.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure on how to translate "bare machine".

Copy link
Contributor

@dallenng dallenng Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, even the french version of the bare metal wikipedia page says bare metal or bare machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBenoit Any thoughts on this?

Copy link
Contributor

@dallenng dallenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see french errors anymore, but it's not a short text and I'm not a french expert, so there could still be some. At least the eye catching ones are gone.

Copy link
Contributor

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Just a few suggestions that you may use or ignore at your convenience 🙂

Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu>
@phil-opp
Copy link
Owner

@alekzus Is this ready to be merged from your side?

@AlexandreMarcq
Copy link
Contributor Author

@alekzus Is this ready to be merged from your side?

Yes, everything is good.

@phil-opp phil-opp merged commit 456ed39 into phil-opp:main Oct 17, 2021
@phil-opp
Copy link
Owner

Great, thanks a lot! And thanks to everybody for reviewing!

@phil-opp
Copy link
Owner

Published at https://os.phil-opp.com/fr/

@phil-opp phil-opp added the translation Translations of the blog into other languages. label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translations of the blog into other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants