Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Fix #362] Fix sign extension bug in `next_table_address` #372
I chose to call it
Also, just something I was thinking about while implementing this, I think someone at some point mentioned the idea of replacing the aliases used in
Awesome, thanks! I like the function name.
Regarding the newtypes for VirtualAddress and PhysicalAddress: I definitely plan to do it for the upcoming second edition (#360). The plan is to move a lot of code to the x86_64 crate and define the newtypes there. The canonical address function would fit in there pretty well, too.
Changing the first edition would be a lot of work, since it touches a lot of code and we would need to adjust almost all posts. So I think it's a better idea to focus on the second edition instead.