New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper size for heap init #376

Merged
merged 2 commits into from Dec 15, 2017

Conversation

2 participants
@robert-w-gries
Contributor

robert-w-gries commented Dec 15, 2017

The LockedHeap.init() function takes heap_bottom and heap_size as arguments. Instead, we pass heap_bottom and heap_top.

This led to unexpected page faults and other weird behavior because the hole sizes were incorrect.

@phil-opp

This comment has been minimized.

Show comment
Hide comment
@phil-opp

phil-opp Dec 15, 2017

Owner

Good catch, seems like we messed something up during the update to the new allocator API. Thanks a lot!

Owner

phil-opp commented Dec 15, 2017

Good catch, seems like we messed something up during the update to the new allocator API. Thanks a lot!

@phil-opp phil-opp merged commit f7868a1 into phil-opp:master Dec 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@robert-w-gries robert-w-gries deleted the robert-w-gries:heap_init branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment