New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more RUST_TARGET_PATH #431

Merged
merged 2 commits into from May 7, 2018

Conversation

1 participant
@phil-opp
Owner

phil-opp commented May 7, 2018

Since rust-lang/rust#49019 Rust supports passing paths as --target (with .json extension). With rust-lang/cargo#5228, Cargo automatically converts these paths to absolute paths, so that the RUST_TARGET_PATH environment variable is no longer neccessary.

The only missing piece was xargo, but unfortunatly the PR at japaric/xargo#205 got no attention. Since there are other unaddressed issues (e.g. japaric/xargo#214) and xargo is in maintainance mode, we decided to create cargo-xbuild as a simplified fork of xargo to fix these issues.

This PR updates the second edition to use cargo xbuild instead of xargo and removes RUST_TARGET_PATH by passing paths as --target.

@phil-opp phil-opp added the relnotes label May 7, 2018

@phil-opp phil-opp added this to the Second Edition milestone May 7, 2018

@phil-opp phil-opp merged commit 1b9ec29 into master May 7, 2018

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bors bors bot deleted the no-more-rust-target-path branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment