New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pc-keyboard crate for translating scancodes #498

Merged
merged 3 commits into from Nov 17, 2018

Conversation

2 participants
@phil-opp
Owner

phil-opp commented Nov 17, 2018

This PR extends the "Hardware Interrupts" post to use the pc-keyboard crate for translating scancodes. This enables us to use all keys and not only 0-9 like before.

Thanks to @ZerothLaw for implementing scancode 1 support in pc-keyboard and of course @thejpster for writing the crate.

@phil-opp phil-opp added the relnotes label Nov 17, 2018

@phil-opp

This comment has been minimized.

Owner

phil-opp commented Nov 17, 2018

@acheronfail How did you manage to get such small GIFs? I tried to add another GIF but it is more than 10 times larger than yours (after compression).

@phil-opp phil-opp force-pushed the pc_keyboard branch from 726d38d to 658ad45 Nov 17, 2018

@acheronfail

This comment has been minimized.

Contributor

acheronfail commented Nov 17, 2018

@phil-opp I just use byzanz which has nice default compression, and usually always results in small GIFs.

You can just apt install byzanz and then its usage is like:

byzanz-record -x 10 -y 10 -w 640 -h 480 ~/Desktop/out.gif

(alternatively it also has some integrations with GTK, just see its help text).

Granted, it's not a fancy GUI app, but it works well and gets the job done.

@phil-opp phil-opp force-pushed the pc_keyboard branch from 658ad45 to 231888e Nov 17, 2018

@phil-opp

This comment has been minimized.

Owner

phil-opp commented Nov 17, 2018

@acheronfail Thanks! It is much smaller now.

@phil-opp

This comment has been minimized.

Owner

phil-opp commented Nov 17, 2018

bors r+

bors bot added a commit that referenced this pull request Nov 17, 2018

Merge #498
498: Use pc-keyboard crate for translating scancodes r=phil-opp a=phil-opp

This PR extends the "Hardware Interrupts" post to use the [`pc-keyboard`](https://docs.rs/pc-keyboard/0.3.1/pc_keyboard/index.html) crate for translating scancodes. This enables us to use all keys and not only 0-9 like before.

Thanks to @ZerothLaw for implementing scancode 1 support in `pc-keyboard` and of course @thejpster for writing the crate.

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors

This comment has been minimized.

Contributor

bors bot commented Nov 17, 2018

@bors bors bot merged commit 231888e into master Nov 17, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@bors bors bot deleted the pc_keyboard branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment