Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite section about no-harness tests #650

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@phil-opp
Copy link
Owner

commented Aug 7, 2019

This pull request replaces the previous panic handler test, which didn't really test any property of our kernel, with a general should_panic test. This simplifies things, for example there is no more panic line constant or special struct for comparing the panic message.

Issue reported in #591 (comment).

Code update in #651.

@phil-opp phil-opp added the relnotes label Aug 7, 2019

@phil-opp phil-opp merged commit 87c64cf into master Aug 7, 2019

1 check passed

phil-opp.blog_os Build #20190807.15 succeeded
Details

@bors bors bot deleted the should-panic-test branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.