Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use panic! instead of println! + loop in double fault handler #687

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@phil-opp
Copy link
Owner

phil-opp commented Nov 22, 2019

With this change, an error message is printed to the serial port when a double fault occurs while running cargo xtest. Before, it would just loop endlessly without any output because println always prints to the VGA buffer, which is not shown for cargo xtest.

The blog post already uses the panic version, it is just the post-06 branch that is out of sync.

Reported in #449 (comment).

This avoids an endless loop when a double fault occurs while running `cargo xtest`.
@phil-opp phil-opp merged commit 3470636 into post-06 Nov 22, 2019
11 of 13 checks passed
11 of 13 checks passed
Test (ubuntu-latest)
Details
Test (ubuntu-latest)
Details
Test (macos-latest)
Details
Test (macos-latest)
Details
Test (windows-latest)
Details
Test (windows-latest)
Details
Check Formatting Check Formatting
Details
Check Formatting Check Formatting
Details
phil-opp.blog_os Build #20191122.1 succeeded
Details
phil-opp.blog_os #20191122.1 succeeded
Details
phil-opp.blog_os (Job linux) Job linux succeeded
Details
phil-opp.blog_os (Job mac) Job mac succeeded
Details
phil-opp.blog_os (Job windows) Job windows succeeded
Details
@phil-opp phil-opp deleted the post-06-new branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.