Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Support for Community Translations #692

Open
wants to merge 14 commits into
base: master
from
Open

Conversation

@phil-opp
Copy link
Owner

phil-opp commented Nov 27, 2019

This pull request adds experimental support for community translations as discussed in #682. It looks like this:

  • Index page:
    image
  • Post:
    image

Please feel free to contribute translations to this pull request by filing pull requests against the translations branch! The naming convention for translated files is index.[lang-code].md where [lang-code] is an IETF language tag such as zh for Chinese or de for German.

Todo:

  • Provide a way to switch languages, at least from the index page. We could for example add small flag buttons for supported languages.
  • Translate the introduction on the index page.
  • Translate UI elements, such as the 'All Posts' link or the 'Comments' heading.

Blocked on getzola/zola#856.

Blocked on getzola/zola#811, as we don't want to use a pre-release of Zola.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Nov 27, 2019

Note: I'm not sure if zh is the best language tag for Chinese. As far as I know there are at least traditional and simplified Chinese, so maybe we need to be more specific here.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Nov 27, 2019

@luojia65 It seems like you already translated some of the content to Chinese at https://github.com/rustcc/writing-an-os-in-rust. Maybe you like to contribute these translations?

@Rustin-Liu

This comment has been minimized.

Copy link

Rustin-Liu commented Nov 27, 2019

Note: I'm not sure if zh is the best language tag for Chinese. As far as I know there are at least traditional and simplified Chinese, so maybe we need to be more specific here.

Yes, the Traditional Chinese tag is zh_TW and the Simplified Chinese tag is zh_CN.
But I think we can only support Simplified Chinese now.
Because Simplified Chinese is more widely used, we may consider Traditional Chinese later.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Nov 27, 2019

Thanks for the info! I updated the language tag to zh-CN.

@phil-opp phil-opp added this to In Progress in Roadmap Nov 27, 2019
We only generate a RSS feed for the default language anyway.
@luojia65

This comment has been minimized.

Copy link

luojia65 commented Nov 28, 2019

@luojia65 It seems like you already translated some of the content to Chinese at
https://github.com/rustcc/writing-an-os-in-rust. Maybe you like to contribute these translations?

Yes I'd love to contribute my translations. If okay, please notify me after the translated site is online, so I could then offer suggestions on Chinese fonts and composing, etc. if applicable.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Nov 28, 2019

Yes I'd love to contribute my translations.

Awesome! Do you want to create a pull request against the translations branch? Alternatively I could also copy the content myself if you don't have the time (I would of course set you as the commit author).

If okay, please notify me after the translated site is online, so I could then offer suggestions on Chinese fonts and composing, etc. if applicable.

Sure, will do! I plan to put it online without linking it from the normal homepage, so that it is only visible if one knows the URLs. This allows us to check the rendering etc. before we present it to the public.

@luojia65

This comment has been minimized.

Copy link

luojia65 commented Nov 28, 2019

Oh I do not have time for now (midterms), please do the copy for me :) @phil-opp

@Rustin-Liu

This comment has been minimized.

Copy link

Rustin-Liu commented Nov 28, 2019

Oh I do not have time for now (midterms), please do the copy for me :) @phil-opp

I think I can help you.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Nov 28, 2019

@Rustin-Liu

I think I can help you.

Great, thanks a lot! I opened a separate PR with an initial copy at #694. There are some parts that are untranslated at the beginning of the posts, maybe you could help adding a translation. Also, it would be great if you could review the PR in general since I don't understand Chinese :).

@wusyong

This comment has been minimized.

Copy link

wusyong commented Dec 2, 2019

Hello, just saw the reddit post and wondering is it possible for me to also translate Traditional Chinese zh-tw at the same time? I have had a look on @luojia65 's work and it seems pretty good already. However, there are still some grammar and terminology differences between them. I would like to make a translation on zh-tw, or if you agree, convert it from Simplified Chinese.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Dec 3, 2019

@wusyong

Hello, just saw the reddit post and wondering is it possible for me to also translate Traditional Chinese zh-tw at the same time?

Sure! Just open a pull request against the translations branch.

I would like to make a translation on zh-tw, or if you agree, convert it from Simplified Chinese.

@luojia65 Is it ok with you if your translation is converted?

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Dec 3, 2019

As a side note: We currently have the problem that the project specifies no license for the blog posts and the translations. The result is that every translator always needs to ask for permission, e.g. when converting other translations. It's also a bit dangerous for me to host translations created by other people with such an unclear copyright situation.

Therefore I plan to add a explicit license for the blog content, likely CC BY-NC. This license would then also apply to contributed translations, which would greatly simplify things. What do you think about this?

@wusyong

This comment has been minimized.

Copy link

wusyong commented Dec 3, 2019

@phil-opp Thanks! Adding explicit license would be great. Don't worry about permission to convert if you guys have any difficulty. I could still start from scratch anyway since I have read this before.

@luojia65

This comment has been minimized.

Copy link

luojia65 commented Dec 3, 2019

@phil-opp Yes I am supportive to all changes of original text. It's okay with me. Some of them make meanings clear, sometimes both are proper but I'd agree with modified version.
I wonder if publishing paperback translated books after permitted would be applicable after one given license. (Just asking, in case of possibility. I still agree to donate my translated text.) The Rust Book is available free online but it's still allowed for Rust community to publish it in paperback.

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Dec 3, 2019

(I'm not a lawyer, so th following might be inaccurate or incorrect.)

I think the current status without a license is that no rights for the blog content are automatically granted. That means you have to explicitly ask me for permission when you want to copy my content or create derivative work (like a translation). Publishing a paperback book requires my permission too.

The same applies when someone else wants to publish a paperback book of your translation: they require explicit permission of both me (the original author) and you (the translator).

The idea of a license is that it automatically grants certain rights to everybody under certain conditions. This means that no explicit permission is required for certain operations, e.g. for hosting a copy of the content somewhere else. For things not allowed by the license you need to explicitly ask for permission, just like without a license.

Let's look at the CC BY-NC license: It does not grant any rights for commercial use, which includes selling a book, so you need to ask for permission before doing it. This does not mean that it's forbidden to publish a book, you just have to make an agreement with all copyright holders. So it also means that I would have to ask you for permission before I can publish a book containing your translation, which seems fair to me.

Other things, like publishing the content online or creating derivative translations, are automatically permitted by the license, so there is no need to ask for permission in these cases. This protects us all from copyright claims, for example no one can suddenly revoke these rights and require fees for hosting the content or the translation.

I hope this clears things up!

@luojia65

This comment has been minimized.

Copy link

luojia65 commented Dec 4, 2019

@phil-opp That seems nice, I'd agree with adding a license. Thanks for your reference explanation!

@luojia65

This comment has been minimized.

Copy link

luojia65 commented Dec 6, 2019

Added CC-BY-NC-4.0 license to our community work.
If any questions please reply me: https://github.com/rustcc/writing-an-os-in-rust/blob/master/LICENSE

@phil-opp

This comment has been minimized.

Copy link
Owner Author

phil-opp commented Dec 12, 2019

I just added a CC BY-NC license to the blog in #705.

@TheBegining Are you willing to license your contributions under the CC BY-NC license too? This would be required for merging your translation included in this PR. If yes, please reply with:

I hereby license my contributions to this pull request under the CC BY-NC license (https://creativecommons.org/licenses/by-nc/4.0/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
In Progress
5 participants
You can’t perform that action at this time.