Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traditional Chinese on chapter 1 #699

Merged
merged 6 commits into from Jan 7, 2020

Conversation

@wusyong
Copy link

wusyong commented Dec 9, 2019

This is first attempt on translation of traditional Chinese for chapter 1. Not sure if I should add commit quote to mark which commit is this page depends on.

cc @phil-opp

wusyong added 2 commits Dec 9, 2019
Copy link
Owner

phil-opp left a comment

Thanks a lot!

I can't review the content itself, but the structure looks good to me overall.

blog/config.toml Outdated Show resolved Hide resolved
@phil-opp

This comment has been minimized.

Copy link
Owner

phil-opp commented Dec 9, 2019

Not sure if I should add commit quote to mark which commit is this page depends on.

That's a very good idea! I think we can even add it as an additional field to the front matter.

@wusyong

This comment has been minimized.

Copy link
Author

wusyong commented Dec 10, 2019

That's a very good idea! I think we can even add it as an additional field to the front matter.

Thanks! Any suggestion on how to add to front matter? Or should I just add it before the first paragraph?

Copy link
Owner

phil-opp left a comment

We recently added a CC BY-NC license for the blog content in #705. Since this pull request was opened before the license was added, I have to explictly ask you:

Do you agree to license your contributions under the CC BY-NC license? This would be required for merging your translation included in this PR. If yes, please reply with:

I hereby license my contributions to this pull request under the CC BY-NC license (https://creativecommons.org/licenses/by-nc/4.0/).

@wusyong

This comment has been minimized.

Copy link
Author

wusyong commented Dec 13, 2019

@phil-opp Yes, I hereby license my contributions to this pull request under the CC BY-NC license (https://creativecommons.org/licenses/by-nc/4.0/).

Btw sorry I'm currently on the flight, so I probably will push those commits and resolve CI problem next Monday.

@phil-opp

This comment has been minimized.

Copy link
Owner

phil-opp commented Dec 13, 2019

@wusyong Great, thank you!

Btw sorry I'm currently on the flight, so I probably will push those commits and resolve CI problem next Monday.

No worries! I want to wait until Zola 0.10 is released before merging the translations branch anyway, so there is no rush.

@phil-opp phil-opp merged commit 4784ec9 into phil-opp:translations Jan 7, 2020
2 of 4 checks passed
2 of 4 checks passed
Zola Build
Details
Zola Check Zola Check
Details
Check Spelling
Details
phil-opp.blog_os Build #20200106.1 failed
Details
@phil-opp

This comment has been minimized.

Copy link
Owner

phil-opp commented Jan 7, 2020

Thanks a lot!

@wusyong

This comment has been minimized.

Copy link
Author

wusyong commented Jan 7, 2020

@phil-opp Thank you too! Sorry I got real busy on something else last month. I think I could keep up the pace in couple weeks.

@phil-opp

This comment has been minimized.

Copy link
Owner

phil-opp commented Jan 7, 2020

No worries for the small delay! We all do this in our free time, so it perfectly fine if other things in life have priority :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.