Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-3 translation refactor #725

Merged
merged 2 commits into from Jan 30, 2020
Merged

post-3 translation refactor #725

merged 2 commits into from Jan 30, 2020

Conversation

hi-rustin
Copy link
Contributor

No description provided.

@phil-opp
Copy link
Owner

Thanks a lot for your continuous translation work! Let me know when this PR is ready for merging.

Maybe @zheli has time for a short review again?

@hi-rustin hi-rustin marked this pull request as ready for review January 28, 2020 09:56
@zheli
Copy link

zheli commented Jan 28, 2020

@phil-opp sure! 😊

zheli
zheli approved these changes Jan 29, 2020
View reviewed changes
Copy link

@zheli zheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@phil-opp
Copy link
Owner

Thanks for reviewing @zheli!

@phil-opp phil-opp merged commit 6d4f1d6 into phil-opp:rustcc-translation Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zheli zheli zheli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hi-rustin @phil-opp @zheli