Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify executor by merging task_queue and wake_queue #804

Merged
merged 2 commits into from May 19, 2020

Conversation

phil-opp
Copy link
Owner

@phil-opp phil-opp commented May 18, 2020

Proposed in #768 (comment)

This pull request also renames the waiting_tasks map to tasks and makes run_ready_tasks operate on &mut Task references instead of removing and re-inserting tasks from the map.

As another simplification, we now use the entry API on the waker_cache map instead of manual if conditions. Unfortunately this requires to destructure self into its fields because RFC 2229 is not yet implemented (see the tracking issue), but I still think that the new approach is simpler.

Also: Use entry API on waker_cache map.
phil-opp added a commit that referenced this issue May 19, 2020
@phil-opp phil-opp added the relnotes label May 19, 2020
@phil-opp phil-opp merged commit f118749 into post-12 May 19, 2020
8 checks passed
@phil-opp phil-opp deleted the post-12-merge-queues branch May 19, 2020
@phil-opp
Copy link
Owner Author

@phil-opp phil-opp commented May 19, 2020

Post update in #805.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant