Skip to content

Remove rlibc and use compiler-builtins-mem feature#865

Merged
phil-opp merged 1 commit into
phil-opp:post-02from
robert-w-gries:remove_rlibc_post-03
Oct 2, 2020
Merged

Remove rlibc and use compiler-builtins-mem feature#865
phil-opp merged 1 commit into
phil-opp:post-02from
robert-w-gries:remove_rlibc_post-03

Conversation

@robert-w-gries
Copy link
Copy Markdown
Contributor

@robert-w-gries robert-w-gries commented Oct 2, 2020 •
edited
Loading

Part of #862

I can also remove the references to rlibc from the blog posts if that saves you time

@phil-opp phil-opp changed the base branch from post-03 to post-02 October 2, 2020 19:41
@phil-opp phil-opp changed the base branch from post-02 to post-03 October 2, 2020 19:41
@phil-opp phil-opp changed the base branch from post-03 to post-02 October 2, 2020 19:50
@phil-opp phil-opp force-pushed the remove_rlibc_post-03 branch from 8a7845a to 2458d42 Compare October 2, 2020 19:50
@phil-opp
Copy link
Copy Markdown
Owner

phil-opp commented Oct 2, 2020

@robert-w-gries Thanks a lot! You missed the base branch by one, as we already introduce rlibc in post-02. I therefore rebased your commit on top of post-02 used GitHub's feature for changing the base branch of this PR.

@phil-opp phil-opp mentioned this pull request Oct 2, 2020
Merged
@phil-opp
Copy link
Copy Markdown
Owner

phil-opp commented Oct 2, 2020

I opened #866 to update the blog for this.

@robert-w-gries
Copy link
Copy Markdown
Contributor Author

robert-w-gries commented Oct 2, 2020

Sorry about that! Thanks for fixing it!

@phil-opp phil-opp merged commit 4e38e7d into phil-opp:post-02 Oct 2, 2020
@phil-opp
Copy link
Copy Markdown
Owner

phil-opp commented Oct 2, 2020

No worries, thanks for the PR!

@phil-opp phil-opp mentioned this pull request Oct 2, 2020
Merged
phil-opp added a commit that referenced this pull request Oct 2, 2020
@phil-opp @robert-w-gries
Update post-04 to use compiler_builtins mem feature instead of `rli…
d4e1f47 
…bc` (#868)

* Remove rlibc and use compiler-builtins-mem feature (#865)

* Update post-04 to use compiler_builtins `mem` feature instead of `rlibc`

Co-authored-by: Rob Gries <robert.w.gries@gmail.com>
@phil-opp phil-opp mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-w-gries @phil-opp