Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rlibc and use compiler-builtins-mem feature #865

Merged
merged 1 commit into from Oct 2, 2020

Conversation

robert-w-gries
Copy link
Contributor

@robert-w-gries robert-w-gries commented Oct 2, 2020

Part of #862

I can also remove the references to rlibc from the blog posts if that saves you time

@phil-opp phil-opp changed the base branch from post-03 to post-02 October 2, 2020 19:41
@phil-opp phil-opp changed the base branch from post-02 to post-03 October 2, 2020 19:41
@phil-opp phil-opp changed the base branch from post-03 to post-02 October 2, 2020 19:50
@phil-opp
Copy link
Owner

phil-opp commented Oct 2, 2020

@robert-w-gries Thanks a lot! You missed the base branch by one, as we already introduce rlibc in post-02. I therefore rebased your commit on top of post-02 used GitHub's feature for changing the base branch of this PR.

@phil-opp
Copy link
Owner

phil-opp commented Oct 2, 2020

I opened #866 to update the blog for this.

@robert-w-gries
Copy link
Contributor Author

Sorry about that! Thanks for fixing it!

@phil-opp phil-opp merged commit 4e38e7d into phil-opp:post-02 Oct 2, 2020
@phil-opp
Copy link
Owner

phil-opp commented Oct 2, 2020

No worries, thanks for the PR!

phil-opp added a commit that referenced this pull request Oct 2, 2020
…bc` (#868)

* Remove rlibc and use compiler-builtins-mem feature (#865)

* Update post-04 to use compiler_builtins `mem` feature instead of `rlibc`

Co-authored-by: Rob Gries <robert.w.gries@gmail.com>
@phil-opp phil-opp mentioned this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants