Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate post 02 to Japanese #871

Merged
merged 23 commits into from Oct 23, 2020

Conversation

woodyZootopia
Copy link
Contributor

@woodyZootopia woodyZootopia commented Oct 18, 2020

This translation uses many experimental techniques e.g. ruby annotation attached to technical terms. So feel free to give us feedback!
Preview of the translation can be seen in https://github.com/phil-opp/blog_os/blob/c166b51c9c9f4525175dc6eab1d92a23c6f2ef9d/blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md

@woodyZootopia woodyZootopia changed the title [WIP] translate post 02 to Japanese translate post 02 to Japanese Oct 20, 2020
@woodyZootopia
Copy link
Contributor Author

@JohnTitor please give me feedback when you have time
@phil-opp you can merge it now or wait till @JohnTitor 's review ends

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I've added comments through reading the translations.

@woodyZootopia
Copy link
Contributor Author

woodyZootopia commented Oct 21, 2020

@JohnTitor Thank you for a detailed and thorough review! (and sorry for a poor translation...)
Except for the replies I made, I agree with your comments. Please give feedback to my replies when you have time.
Since you made such a big contribution to the translation, I'd like to add you as the co-translator of the post. Is it OK with you?

@JohnTitor
Copy link
Contributor

@woodyZootopia No worries! The translations overall look great. And that's why the review is important :)

Please give feedback to my replies when you have time.

Left comments to them.

Since you made such a big contribution to the translation, I'd like to add you as the co-translator of the post. Is it OK with you?

Yeah, of course, thanks <3

woodyZootopia and others added 17 commits October 23, 2020 08:59
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@JohnTitor
Copy link
Contributor

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@woodyZootopia
Copy link
Contributor Author

woodyZootopia commented Oct 23, 2020

@JohnTitor Thank you, I didn't know that! It saved me tons of clicks (and sorry for sending you lots of notifications)

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation part looks great to me, thanks!

@phil-opp it's ready to review on your end :)

@phil-opp
Copy link
Owner

Thanks a lot for your work @woodyZootopia and thanks to @JohnTitor for reviewing.

@phil-opp phil-opp merged commit 85b7d4b into phil-opp:master Oct 23, 2020
@phil-opp
Copy link
Owner

The new post is available at https://os.phil-opp.com/ja/minimal-rust-kernel/

@woodyZootopia woodyZootopia deleted the translate_post_02 branch November 11, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants