-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
translate post 02 to Japanese #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JohnTitor please give me feedback when you have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! I've added comments through reading the translations.
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md
Outdated
Show resolved
Hide resolved
@JohnTitor Thank you for a detailed and thorough review! (and sorry for a poor translation...) |
@woodyzootopia No worries! The translations overall look great. And that's why the review is important :)
Left comments to them.
Yeah, of course, thanks <3 |
1fd02e1
to
f72f8ed
Compare
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
….ja.md Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@woodyzootopia Btw you can apply suggestions as a batch: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request |
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@JohnTitor Thank you, I didn't know that! It saved me tons of clicks (and sorry for sending you lots of notifications) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation part looks great to me, thanks!
@phil-opp it's ready to review on your end :)
Thanks a lot for your work @woodyzootopia and thanks to @JohnTitor for reviewing. |
The new post is available at https://os.phil-opp.com/ja/minimal-rust-kernel/ |
This translation uses many experimental techniques e.g. ruby annotation attached to technical terms. So feel free to give us feedback!
Preview of the translation can be seen in https://github.com/phil-opp/blog_os/blob/c166b51c9c9f4525175dc6eab1d92a23c6f2ef9d/blog/content/second-edition/posts/02-minimal-rust-kernel/index.ja.md