Skip to content

Translate post-03 to Japanese #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Conversation

swnakamura
Copy link
Contributor

The title says it all.
@JohnTitor could you review the translation?

@swnakamura swnakamura marked this pull request as ready for review December 8, 2020 08:54
@JohnTitor
Copy link
Contributor

Hey, thanks for translating and the ping! I'd like to review in the next week, but seems your branch is messed up?

@swnakamura
Copy link
Contributor Author

@JohnTitor Thank you! and I fixed the messed-up branch by rebasing to the master.

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor wording improvements but almost looks great!

chars: [[ScreenChar; BUFFER_WIDTH]; BUFFER_HEIGHT],
}
```
Rustにおいて、デフォルトの構造体におけるフィールドの並べ方は未定義なので、[`repr(C)`]属性が必要になります。これは、構造体のフィールドがCの構造体と全く同じように並べられることを保証してくれるので、フィールドの並べ方が正しいと保証してくれるのです。`Buffer`構造体については、[`repr(transparent)`]をもう一度使うことで、その唯一のフィールドと同じメモリレイアウトを持つようにしています。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid using "保証" twice here but I have no better idea at all. It'd be great if we could improve it but it's fine to remain as-is.

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@swnakamura
Copy link
Contributor Author

swnakamura commented Dec 16, 2020

@JohnTitor Thank you! Your suggestion makes the translation way more natural. I love it.
Can I add you as a co-translator as we did in post-02?

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my end.

@JohnTitor
Copy link
Contributor

Can I add you as a co-translator as we did in post-02?

Yeah, of course!

@swnakamura
Copy link
Contributor Author

@phil-opp review process is completed! Could you merge this PR?

@phil-opp phil-opp merged commit b5a1360 into phil-opp:master Dec 17, 2020
@phil-opp
Copy link
Owner

Thanks a lot!

@phil-opp
Copy link
Owner

Published at https://os.phil-opp.com/ja/vga-text-mode/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants