Translate post-03 to Japanese - #887
Conversation
|
Hey, thanks for translating and the ping! I'd like to review in the next week, but seems your branch is messed up? |
84422f0 to
d36c041
Compare
|
@JohnTitor Thank you! and I fixed the messed-up branch by rebasing to the master. |
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Left some minor wording improvements but almost looks great!
| chars: [[ScreenChar; BUFFER_WIDTH]; BUFFER_HEIGHT], | ||
| } | ||
| ``` | ||
| Rustにおいて、デフォルトの構造体におけるフィールドの並べ方は未定義なので、[`repr(C)`]属性が必要になります。これは、構造体のフィールドがCの構造体と全く同じように並べられることを保証してくれるので、フィールドの並べ方が正しいと保証してくれるのです。`Buffer`構造体については、[`repr(transparent)`]をもう一度使うことで、その唯一のフィールドと同じメモリレイアウトを持つようにしています。 |
There was a problem hiding this comment.
I'd avoid using "保証" twice here but I have no better idea at all. It'd be great if we could improve it but it's fine to remain as-is.
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
|
@JohnTitor Thank you! Your suggestion makes the translation way more natural. I love it. |
Yeah, of course! |
|
@phil-opp review process is completed! Could you merge this PR? |
|
Thanks a lot! |
|
Published at https://os.phil-opp.com/ja/vga-text-mode/ |
3 participants
The title says it all.
@JohnTitor could you review the translation?