Translate post-03 to Japanese #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for translating and the ping! I'd like to review in the next week, but seems your branch is messed up? |
swnakamura
force-pushed
the
translate_post_03
branch
from
84422f0 to
d36c041
Compare
|
@JohnTitor Thank you! and I fixed the messed-up branch by rebasing to the master. |
JohnTitor
reviewed
Dec 16, 2020
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
| chars: [[ScreenChar; BUFFER_WIDTH]; BUFFER_HEIGHT], | ||
| } | ||
| ``` | ||
| Rustにおいて、デフォルトの構造体におけるフィールドの並べ方は未定義なので、[`repr(C)`]属性が必要になります。これは、構造体のフィールドがCの構造体と全く同じように並べられることを保証してくれるので、フィールドの並べ方が正しいと保証してくれるのです。`Buffer`構造体については、[`repr(transparent)`]をもう一度使うことで、その唯一のフィールドと同じメモリレイアウトを持つようにしています。 |
There was a problem hiding this comment.
I'd avoid using "保証" twice here but I have no better idea at all. It'd be great if we could improve it but it's fine to remain as-is.
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
blog/content/second-edition/posts/03-vga-text-buffer/index.ja.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
|
@JohnTitor Thank you! Your suggestion makes the translation way more natural. I love it. |
Yeah, of course! |
|
@phil-opp review process is completed! Could you merge this PR? |
|
Thanks a lot! |
|
Published at https://os.phil-opp.com/ja/vga-text-mode/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all.
@JohnTitor could you review the translation?