Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate post-04 to Japnese #903

Merged
merged 5 commits into from Jan 12, 2021

Conversation

swnakamura
Copy link
Contributor

The title says it all.
@JohnTitor Could you review it for me?

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this, we've now translated the "Bare Bones" part of the blog, yay 🎉
Left some suggestions/comments as usual otherwise looks great to me.
Thanks for your work!

blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved

<div class="note">

**訳注:** [最小のカーネル][_A Minimal Rust Kernel_]の記事が日本語に翻訳されたのはこの日より後なので、あなたがこのサイトを日本語で閲覧している場合は特に問題はありません。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved
blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved
blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved
blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved
blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved
blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved

`should_fail`関数を`_start`関数から直接呼び出して、もしリターンしたら失敗の終了コードで終了するようにしました。今`cargo test --test should_panic`を実行しても、以前と全く同じように振る舞います。

`should_panic`なテストを作るとき以外にも`harness`属性は有用なことがあります。例えば、それぞれのテスト関数が副作用を持っており、指定された順番で実行されないといけないときなどです。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: translation for "for complex integration tests" is missing but it would be okay as we know that context (and someone maybe finds it redundant).

blog/content/edition-2/posts/04-testing/index.ja.md Outdated Show resolved Hide resolved
swnakamura and others added 2 commits January 11, 2021 12:02
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@swnakamura
Copy link
Contributor Author

@JohnTitor Thank you very much!
I added you as the co-translator as usual. If that's OK, let's tell phil-opp that the translation is complete.

@JohnTitor
Copy link
Contributor

I added you as the co-translator as usual. If that's OK, let's tell phil-opp that the translation is complete.

Yeah, that's fine, thanks!

@phil-opp It looks good on my end.

@phil-opp phil-opp merged commit 16b9e30 into phil-opp:master Jan 12, 2021
@phil-opp
Copy link
Owner

Thanks a lot to both of you!

@swnakamura swnakamura deleted the translate_post_04_ja branch January 12, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants