Translate the index page to Japanese - #907
Merged
Merged
Conversation
JohnTitor
approved these changes
Jan 12, 2021
JohnTitor
left a comment
JohnTitor
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Left some comments, mainly about the title.
| +++ | ||
|
|
||
| <h1 style="visibility: hidden; height: 0px; margin: 0px; padding: 0px;">Writing an OS in Rust</h1> | ||
| <h1 style="visibility: hidden; height: 0px; margin: 0px; padding: 0px;">RustでOSを書く</h1> |
Contributor
There was a problem hiding this comment.
"Writing an OS in Rust" is the title and I'd like to remain as-is (like "the book" or "TRPL").
Contributor
Author
There was a problem hiding this comment.
I think translating this would help the search engine bots, and make this blog reach more Japanese reader? (this text is hidden so only robots read it)
Contributor
There was a problem hiding this comment.
I thought people use "Writing an OS in Rust" for search anyway but realized it will show the original and a Japanese title will lead to more search results. I'm fine with this then 👍
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Contributor
Author
|
@phil-opp translation and review is complete. Please merge this. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translated the index page.
@JohnTitor please review it!