Skip to content

Add ja translation for double faults - #917

Merged
phil-opp merged 34 commits into
phil-opp:masterfrom
garasubo:post-06-ja
Feb 23, 2021
Merged

Add ja translation for double faults#917
phil-opp merged 34 commits into
phil-opp:masterfrom
garasubo:post-06-ja

Conversation

@garasubo

@garasubo garasubo commented Jan 31, 2021

Copy link
Copy Markdown
Contributor

Resolve #915

Japanese translation for "Double Faults" section

This is my first time PR, so feel free to point out if I'm in the wrong way.

@phil-opp

phil-opp commented Feb 2, 2021

Copy link
Copy Markdown
Owner

Thanks a lot for creating the translation! I'm not speaking Japanese myself, but maybe @JohnTitor or @woodyzootopia could take a look?

@swnakamura

swnakamura commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

Thank you very much! I think it's really good. There are only a few advice:

  • JohnTitor is added as co-translator since he always corrects my translation. You need not add him as for now. (I think he'll help you as well though!)
  • I think it's not usual to use italic characters (イタリック体) to emphasize in Japanese. I'd prefer converting it bold(太字).
  • It would be more kind to change URLs to the websites in English to the ones in Japanese when translation is available (for example, Wikipedia 日本語版 or Rust by Example 日本語版).

There are other minor mistakes, but they can be corrected after all translation is done. Keep going!

@garasubo

Copy link
Copy Markdown
Contributor Author

All sections are translated.

TODO: Replace URLs for English website with those for Japanese websites if exist

@garasubo garasubo changed the title WIP: add ja tranlation for double faults ad ja tranlation for double faults Feb 13, 2021
@garasubo garasubo changed the title ad ja tranlation for double faults add ja tranlation for double faults Feb 13, 2021
@garasubo

Copy link
Copy Markdown
Contributor Author

Replaced wikipedia links and Rust official document links to those for Japanese. Confirmed that all CI checks passed.
@JohnTitor @woodyzootopia Could you review this PR?

@swnakamura

Copy link
Copy Markdown
Contributor

Sorry for the delay in response. I've been really busy with my jobs until next week or so, so it's difficult to review your translation for now. Very sorry.

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating and sorry for the delay! Left some reviews roughly but almost looks great to me :)

Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
Comment thread blog/content/edition-2/posts/06-double-faults/index.ja.md Outdated
@JohnTitor

Copy link
Copy Markdown
Contributor

Btw, IIRC "Solve #XXX" won't close the issue, you should use "resolve", "close", or "fix" instead.

garasubo and others added 11 commits February 21, 2021 11:19
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
garasubo and others added 13 commits February 21, 2021 11:24
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @garasubo!

@woodyzootopia I think it's good to go ahead as-is and follow-up stuff when you get some time to review, does it work for you?

@swnakamura

Copy link
Copy Markdown
Contributor

Yes, thank you! I'm still not able to check the translation, so please proceed! I will create another PR/Issue if I were to find any problem.

@phil-opp phil-opp changed the title add ja tranlation for double faults Add ja translation for double faults Feb 23, 2021
@phil-opp

Copy link
Copy Markdown
Owner

Ok great, thanks a lot!

@phil-opp
phil-opp merged commit 9d38172 into phil-opp:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Japanese translation of chapters 6 (Double Fault)

4 participants