Add ja translation for double faults - #917
Conversation
|
Thanks a lot for creating the translation! I'm not speaking Japanese myself, but maybe @JohnTitor or @woodyzootopia could take a look? |
|
Thank you very much! I think it's really good. There are only a few advice:
There are other minor mistakes, but they can be corrected after all translation is done. Keep going! |
TODO: replace all links to jp pages if exists
|
All sections are translated. TODO: Replace URLs for English website with those for Japanese websites if exist |
|
Replaced wikipedia links and Rust official document links to those for Japanese. Confirmed that all CI checks passed. |
|
Sorry for the delay in response. I've been really busy with my jobs until next week or so, so it's difficult to review your translation for now. Very sorry. |
JohnTitor
left a comment
There was a problem hiding this comment.
Thanks for translating and sorry for the delay! Left some reviews roughly but almost looks great to me :)
|
Btw, IIRC "Solve #XXX" won't close the issue, you should use "resolve", "close", or "fix" instead. |
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
JohnTitor
left a comment
There was a problem hiding this comment.
Thanks @garasubo!
@woodyzootopia I think it's good to go ahead as-is and follow-up stuff when you get some time to review, does it work for you?
|
Yes, thank you! I'm still not able to check the translation, so please proceed! I will create another PR/Issue if I were to find any problem. |
|
Ok great, thanks a lot! |
Resolve #915
Japanese translation for "Double Faults" section
This is my first time PR, so feel free to point out if I'm in the wrong way.