Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Mar 29, 2015
  1. @smblott-github

    Move the search-engine logic out of settings.coffee.

    smblott-github authored
    This logic should never have been in settings.coffee.  This moves it to completion.coffee, where it belongs.
Commits on Mar 25, 2015
  1. @smblott-github

    Check isEnabledForURL on hash change.

    smblott-github authored
    If an exclusion rule depends on the hash/anchor, then we're not picking
    it up.  Here's a concrete example of this:
    
       - https?://ca*.computing.dcu.ie/[0-9]*-*#*
    
    (which matches slides prepared via "slidy").  The initial URL does not
    include the anchor/hash, so we miss the exclusion rule.  The page is
    bounced immediately to an anchor/hash for which the rule should apply,
    and we miss it.
    
    (There may be other ways in which the URL can change (WebNavigation?),
    we need to look into this.)
Commits on Mar 17, 2015
  1. @smblott-github

    Merge branch 'rework-exclusion-rules'

    smblott-github authored
    Conflicts:
    	content_scripts/vimium_frontend.coffee
Commits on Mar 15, 2015
  1. @smblott-github
  2. @smblott-github
  3. @smblott-github

    Fill in "pages/blank.html" is an absolute URL.

    smblott-github authored
    "pages/blank.html" was being sent to the default search engine by
    chrome.tabs.create().
    
    Not fully functional.  New tabs created from incognito mode are created
    in a non-incognito mode window.
  4. @smblott-github
  5. @smblott-github

    Rework page icon handling.

    smblott-github authored
    Setting the page icon is now driven from the corrently-active frame.
    
    - Eliminates a race condition.
    - Icon matches actual frame state (not tab URL state).
    - Exclusion-rule changes propagate to all frames.
  6. @smblott-github

    Propagate exclusion rules to all frames.

    smblott-github authored
    When the active tab changes, we call updateActiveState to update the
    icon and propagate any changed exclusion-rule state to the tab.  All
    frames received the request.  However, only one response is received by
    the background page.  Therefore, new exclusion rules are only propagated
    to one frame.
    
    Here's what can go wrong...
    
    On gmail, open the hangouts frame.  Add an exclusion rule sepcific to
    the hangouts frame.  Save it.  The update is propagated only to the main
    frame.  The new exclusion rule is not in effect in the hangouts frame.
    That's wierd and obviously wrong.
    
    In this commit, every frame receiving the getActiveState request also
    calls checkIfEnabledForUrl to ensure that any new exclusion-rule state
    is propagated.  This is overkill, to some extent.  We should really move
    settings to chrome.storage and have each frame check locally for changes
    affecting it.
  7. @smblott-github

    Populate popup with frame's URL.

    smblott-github authored
    Previously, we have been populating the suggested exclusion URL in the
    page popup with the tab's URL.  This uses the active frame's URL
    instead:
    
    - because this is the URL which will affect the current frame (without
      this, a user can naively add an exclusion rule and it has no effect),
      and
    
    - because, without this, the user has no reasonable way to add exclusion
      rules for frames such as the hangouts frame on gmail (for which, the
      URL is not displayed in the address bar).
  8. @smblott-github

    Fix frame-focus detection.

    smblott-github authored
    In b05276e, I inadvertently moved the
    focus handler from window to document.  As a consequence, detectFocus
    (now registerFocus) wasn't being called when expected.
  9. @smblott-github

    Fix frame-focus detection.

    smblott-github authored
    In b05276e, I inadvertently moved the
    focus handler from window to document.  As a consequence, detectFocus
    (now registerFocus) wasn't being called when expected.
Commits on Mar 11, 2015
  1. @smblott-github

    Merge pull request #1527 from smblott-github/fix-scrolling

    smblott-github authored
    Move Scroller.init() up the handler stack.
  2. @smblott-github

    Move Scroller.init() up the handler stack.

    smblott-github authored
    Move scroller initialisation so that its key handlers are above insert
    mode in the handler stack.  This ensures that the scroller sees keyup
    events if we enter insert mode while continuous scrolling.
    
    Fixes #1526.
Commits on Mar 9, 2015
  1. @smblott-github

    Inject content scripts on install/upgrade only.

    smblott-github authored
    We should not inject content scripts on chrome upgrades.
  2. @smblott-github

    Pass keyup events after entering link-hint mode.

    smblott-github authored
    The page (or another extension) sees keydown events (such as shift)
    before entering link-hint mode.  So we need to also pass the
    corresponding keyup events.
    
    Fixes #1522.
Commits on Mar 8, 2015
  1. @smblott-github
  2. @smblott-github
  3. @smblott-github
  4. @smblott-github
Commits on Mar 7, 2015
  1. @smblott-github

    Reload content scripts after install/update.

    smblott-github authored
    This is @mrmr1993's work from #1041.
    
    Reload content scripts when vimium is installed or updates.
    
    (@mrmr1993:  The automatic merge was really messy (or, at least, I
    couldn't figure out what was going on).  Since the bulk of #1041 was
    actually quite compact, I took the liberty of just copying it in.  Hope
    you don't mind.)
  2. @smblott-github
  3. @smblott-github
Commits on Mar 6, 2015
  1. @smblott-github

    Remove need for short delay to prevent vomnibar flicker.

    smblott-github authored
    This delivers a "hidden" massage to the vomnibar after the vomnibar has
    been hiddent in the host page.  The vomnibar only performs whatever
    action is required when it receives this "hidden" message.
  2. @smblott-github

    Correctly remove event listeners.

    smblott-github authored
    Fix oversight from #1517.
  3. @smblott-github

    Add short delay before launching from vomnibar.

    Stephen Blott authored smblott-github committed
    This is not entirely satisfactory.  It would be great if a delay of 0
    worked (a la `nextTick`).  But it seems we need a little longer because
    we need to allow the UI component messaging to complete.
    
    An alternative would be to thread the action required through the UI
    component logic.  But that's pretty ugly too.
    
    Yet another alternative would be to have the UI Component post an "ok,
    we're done, do it" message once the UI component has been removed.
    
    Fixes #1485.
  4. @smblott-github
  5. @smblott-github
  6. @smblott-github

    Cosmetic changes (following #1490).

    smblott-github authored
    Mainly fix the indentation on comments.  Also tweak wording a bid.
Commits on Mar 5, 2015
  1. @smblott-github

    Fix various vomnibar clicks...

    smblott-github authored
    Click:
    - in the vomnibar focuses the input
    - anywhere else (such as in the space below the vomnibar) hides the
      vomnibar.
    
    This makes clicks in the space below the vomnibar behave the same as
    clicks in the page itself...  Which makes sense, because the difference
    is not apparent to the user.
  2. @smblott-github

    Hide vomnibar if host frame regains focus.

    smblott-github authored
    Fixes #1506.
    
    This takes the opposite approach to #1511.  Instead of hiding the
    vomnibar when it blurs, we hide it when it's host frame is focused.
  3. @smblott-github

    Quick fix for issue creating new tabs.

    smblott-github authored
    This is a quick fix only (to keep master in a functional state).
    openUrlInNewTab is broken, and needs to be refactored.
  4. @smblott-github
  5. @smblott-github
  6. @smblott-github
Something went wrong with that request. Please try again.