Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimium 1.50: Excluded keys string collapses spaces #1585

Closed
infokiller opened this issue Apr 27, 2015 · 3 comments · Fixed by #1591
Closed

Vimium 1.50: Excluded keys string collapses spaces #1585

infokiller opened this issue Apr 27, 2015 · 3 comments · Fixed by #1591

Comments

@infokiller
Copy link

For example, if I set the string "j k" to site-specific excluded keys, after saving the options and opening them again it becomes "jk".
@smblott-github
Copy link
Collaborator

@infokiller. Right enough. That's not necessary.

@infokiller
Copy link
Author

You mean that the parsing is not affected by the whitespace?

@smblott-github
Copy link
Collaborator

No, I mean collapsing the whitespace is not necessary. We'll fix it.

smblott-github added a commit to smblott-github/vimium that referenced this issue Apr 27, 2015
@smblott-github
Do not remove inner whitespace from passkeys.
c237fd4 
Fixes philc#1585.
@smblott-github smblott-github mentioned this issue Apr 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not remove inner whitespace from passkeys configuration smblott-github/vimium
2 participants
@smblott-github @infokiller