Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not functioning on github htmlpreview #2404

Open
Jeffdude opened this issue Jan 22, 2017 · 2 comments
Open

Not functioning on github htmlpreview #2404

Jeffdude opened this issue Jan 22, 2017 · 2 comments

Comments

@Jeffdude
Copy link

Example link here.

I haven't looked into why this may be, I just thought I'd report this for someone smarter to quickly determine if this is a bug or not.

Chrome version: Version 55.0.2883.87 m (64-bit)
Vimium version: 1.58 beta

@smblott-github
Copy link
Collaborator

Confirmed.

@gdh1995
Copy link
Contributor

gdh1995 commented Jan 25, 2017

I've confirmed that this page uses document.open() which will reset the whole page and clear all event listeners.

gdh1995 added a commit to gdh1995/vimium-c that referenced this issue Jun 28, 2017
related issues: philc/vimium#2404

`document.open` will clear all event listeners,
    making Vimium/Vimium++ not respond on user inputs.
This commit can re-add listeners if an child iframe gets focused
    by Vimium++ commands (not user's clicks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants